Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Android Studio .idea files in project #635

Merged
merged 3 commits into from
Feb 8, 2019

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jan 18, 2019

It would be nice for this to be part of the next major release for Cordova 9 (apache/cordova#10).

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #635 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   64.66%   64.66%           
=======================================
  Files          18       18           
  Lines        1817     1817           
=======================================
  Hits         1175     1175           
  Misses        642      642

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715ce2f...c732f56. Read the comment docs.

@Menardi
Copy link
Contributor

Menardi commented Feb 8, 2019

I would say squash the commits before merging, but otherwise this is a good addition.

@brodycj brodycj merged commit 4abe3d3 into apache:master Feb 8, 2019
@brodycj brodycj deleted the ignore-android-studio-idea-files branch February 8, 2019 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants