Call new method CordovaPlugin.onRequestPermissionsResult#1855
Open
GitToTheHub wants to merge 1 commit intoapache:masterfrom
Open
Call new method CordovaPlugin.onRequestPermissionsResult#1855GitToTheHub wants to merge 1 commit intoapache:masterfrom
CordovaPlugin.onRequestPermissionsResult#1855GitToTheHub wants to merge 1 commit intoapache:masterfrom
Conversation
- Fixes apache#1388 - `CordovaInterfaceImpl` called the deprecated method `CordovaPlugin.onRequestPermissionResult` but not the new one. Now the one will also be called. - Renamed `CordovaInterfaceImpl.onRequestPermissionResult` to `CordovaInterfaceImpl.onRequestPermissionsResult` to reflect the new method name
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
===========================================
- Coverage 72.12% 60.79% -11.33%
===========================================
Files 23 23
Lines 1844 4811 +2967
===========================================
+ Hits 1330 2925 +1595
- Misses 514 1886 +1372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CordovaInterfaceImplcalled the deprecated methodCordovaPlugin.onRequestPermissionResultbut not the new oneCordovaPlugin.onRequestPermissionsResult. Now it will be called also.CordovaInterfaceImpl.onRequestPermissionResulttoCordovaInterfaceImpl.onRequestPermissionsResultto reflect the new method namePlatforms affected
Motivation and Context
Description
Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))