Add IMAPReply tests and documentation fixes

[jkbkupczyk]

• Updates ImapReply::isContinuation documentation to reflect method contract
• Fixes some Javadoc typos in AuthenticatingIMAPClient::AUTH_METHOD
• Migrates IMAPTest to JUnit5
• Adds IMAPReply tests (all data for tests comes from RFC-3501))

I also wonder, can we maybe add junit-jupiter-params artifact to the project, so we can write parameterized tests?

FYI: @kinow @garydgregory

[kinow]

Changes look good to me. The GH Actions failure has a test failure but that's already happening on master. Thanks @jkbkupczyk

[jkbkupczyk]

question here, are those comments (kate: ident...) necessary?

[garydgregory]

Let's fix master before we do anything else. I'll look today.

It is ok to add the Junit test dependency for parameterized testing.

[garydgregory]

@jkbkupczyk

OK, I finally nailed the bulletproofing on the failing test.

Would you please rebase this PR on master? Then we should see a green build...

TY!

[garydgregory]

@jkbkupczyk Please rebase on master.

[garydgregory]

Ah, no, got another random failure on master for Java 8 on Windows, which is what I am using locally... still worth it rebase though. @kinow Any ideas?

[garydgregory]

@jkbkupczyk

OK, now you can rebase.

[kinow]

Still seeing the same failure I saw yesterday on master. I have a Windows VM at $work, but haven't had much time to set up or test anything on that machine (using that to write docs/sharepoint/etc 😞 ). Maybe someone else can reproduce and try to fix the test on Win.

[garydgregory]

This PR looks odd, you need to only have your commits in here. Git can be tricky sometimes...

[jkbkupczyk]

This PR looks odd, you need to only have your commits in here. Git can be tricky sometimes...

ahh, I did it through Intellij, should have done it manually...

[garydgregory]

😜 time to redo it then

[jkbkupczyk]

😜 time to redo it then

ok 😁 will close that PR and open a new one, maybe I enhance this change and add parameterized tests 😀

[garydgregory]

You don't need to close this PR and open a new one, this creates noise on the mailing list and disconnects the history of the issue. It's better to keep it here IMO.

[jkbkupczyk]

I think it's good RN. Would you mind looking at this @garydgregory, please?

[garydgregory]

I kicked off the builds...

[jkbkupczyk]

Thank you @garydgregory and @kinow for review 😊