Skip to content

[LANG-1282] Preserve non-breaking spaces in normalizeSpace - #1809

Open
glebchik228 wants to merge 3 commits into
apache:masterfrom
glebchik228:LANG-1282
Open

glebchik228 wants to merge 3 commits into
apache:masterfrom
glebchik228:LANG-1282

Conversation

@glebchik228

Copy link
Copy Markdown

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

Description

Fixes LANG-1282.

StringUtils.normalizeSpace currently replaces non-breaking spaces
(U+00A0) with regular ASCII spaces.

This is inconsistent with the method's use of Character.isWhitespace,
which does not consider U+00A0 to be whitespace.

This change:

  • adds regression tests covering non-breaking spaces;
  • preserves non-breaking spaces instead of converting them to regular spaces;
  • updates the existing test expectation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant