Use String#isEmpty()

apache · Nov 28, 2023 · 49f325b · 49f325b
1 parent ef9543b
commit 49f325b
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/BundleTag.java
@@ -163,7 +163,7 @@ public static LocalizationContext getLocalizationContext(JellyContext jellyConte
         LocalizationContext locCtxt = null;
         ResourceBundle bundle = null;
 
-        if ((basename == null) || basename.equals("")) {
+        if ((basename == null) || basename.isEmpty()) {
             return new LocalizationContext();
         }
 

diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/FormatDateTag.java
@@ -163,7 +163,7 @@ public void doTag(XMLOutput output) throws JellyTagException {
             // Set time zone
             TimeZone tz = null;
             if ((etimeZone instanceof String)
-            && ((String) etimeZone).equals("")) {
+            && ((String) etimeZone).isEmpty()) {
                 etimeZone = null;
             }
             if (etimeZone != null) {

diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetLocaleTag.java
@@ -67,7 +67,7 @@ public void doTag(XMLOutput output) throws JellyTagException {
         if (valueInput == null) {
             locale = Locale.getDefault();
         } else if (valueInput instanceof String) {
-            if (((String) valueInput).trim().equals("")) {
+            if (((String) valueInput).trim().isEmpty()) {
                 locale = Locale.getDefault();
             } else {
                 locale = parseLocale((String) valueInput, (String) variantInput);

diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/SetTimeZoneTag.java
@@ -58,7 +58,7 @@ public void doTag(XMLOutput output) throws JellyTagException {
             timeZone = TimeZone.getTimeZone("GMT");
         }
         else if (valueInput instanceof String) {
-            if (((String) valueInput).trim().equals("")) {
+            if (((String) valueInput).trim().isEmpty()) {
                 timeZone = TimeZone.getTimeZone("GMT");
             } else {
                 timeZone = TimeZone.getTimeZone((String) valueInput);

diff --git a/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java b/jelly-tags/fmt/src/main/java/org/apache/commons/jelly/tags/fmt/TimeZoneTag.java
@@ -74,7 +74,7 @@ public void doTag(XMLOutput output) throws JellyTagException {
             timeZone = TimeZone.getTimeZone("GMT");
         }
         else if (valueInput instanceof String) {
-            if (((String) valueInput).trim().equals("")) {
+            if (((String) valueInput).trim().isEmpty()) {
                 timeZone = TimeZone.getTimeZone("GMT");
             } else {
                 timeZone = TimeZone.getTimeZone((String) valueInput);

diff --git a/jelly-tags/interaction/src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java b/jelly-tags/interaction/src/main/java/org/apache/commons/jelly/tags/interaction/AskTag.java
@@ -187,7 +187,7 @@ public void doTag(XMLOutput output) {
                 // trim the input for tab completion
                 input = input.trim();
 
-                if (defaultInput != null && input.trim().equals("")) {
+                if (defaultInput != null && input.trim().isEmpty()) {
                     input = defaultInput;
                 }
             } else {

diff --git a/jelly-tags/soap/src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java b/jelly-tags/soap/src/main/java/org/apache/commons/jelly/tags/soap/InvokeTag.java
@@ -85,7 +85,7 @@ public void doTag(XMLOutput output) throws MissingAttributeException, JellyTagEx
             call.setTargetEndpointAddress(new java.net.URL(endpoint));
             call.setOperationName(new QName(namespace, method));
 
-            if ( userName != null && !userName.equals("") ) {
+            if ( userName != null && !userName.isEmpty() ) {
                 call.setUsername( userName );
                 call.setPassword( password );
             }