IOUtils.toByteArray now throws EOFException when not enough data is available#796
Merged
garydgregory merged 1 commit intomasterfrom Oct 4, 2025
Merged
IOUtils.toByteArray now throws EOFException when not enough data is available#796garydgregory merged 1 commit intomasterfrom
IOUtils.toByteArray now throws EOFException when not enough data is available#796garydgregory merged 1 commit intomasterfrom
Conversation
The implementation of `IOUtils.toByteArray(InputStream, int, int)` added in #776 throws different exceptions depending on the requested size: * For request sizes larger than the internal chunk size, it correctly throws an `EOFException`. * For smaller requests, it incorrectly throws a generic `IOException`. This PR makes the behavior consistent by always throwing an `EOFException` when the stream ends prematurely. Note: This also affects `RandomAccessFiles.read`. Its previous truncation behavior was undocumented and inconsistent with `RandomAccessFile.read` (which reads as much as possible). The new behavior is not explicitly documented here either, since it is unclear whether throwing on truncation is actually desirable.
garydgregory
changed the title
IOUtils.toByteArrayIOUtils.toByteArray now throws EOFException when not enough data is available
garydgregory
added a commit
that referenced
this pull request
Oct 4, 2025
Member
|
Merged, thank you @ppkarwasz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
IOUtils.toByteArray(InputStream, int, int)added in #776 throws different exceptions depending on the requested size:EOFException.IOException.This PR makes the behavior consistent by always throwing an
EOFExceptionwhen the stream ends prematurely.Note
This also affects
RandomAccessFiles.read. Its previous truncation behavior was undocumented and inconsistent withRandomAccessFile.read(which reads as much as possible). The new behavior is not explicitly documented here either, since it is unclear whether throwing on truncation is actually desirable.