Add missing read argument validation in IOUtils#795
Merged
garydgregory merged 2 commits intomasterfrom Oct 3, 2025
Merged
Conversation
In #790 I introduced `IOUtils#checkIndexFromLength` calls to validate arguments across the codebase. Ironically, the `IOUtils` class itself was left out. This PR addresses that omission by adding argument validation to `IOUtils#read` and `IOUtils#readFully`. Key points: * Ensures consistency with the rest of Commons IO by validating `offset` and `length`. * Fixes inconsistent exception behavior: * Previously, `length < 0` resulted in an `IllegalArgumentException`. * `offset < 0` did not trigger validation and failed later with an `IndexOutOfBoundsException`. * With this change, both invalid cases are handled consistently and upfront.
Member
|
Merged, thank you @ppkarwasz. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #790 I introduced
IOUtils#checkIndexFromLengthcalls to validate arguments across the codebase. Ironically, theIOUtilsclass itself was left out.This PR addresses that omission by adding argument validation to
IOUtils#readandIOUtils#readFully.Key points:
Ensures consistency with the rest of Commons IO by validating
offsetandlength.Fixes inconsistent exception behavior:
length < 0resulted in anIllegalArgumentException.offset < 0did not trigger validation and failed later with anIndexOutOfBoundsException.With this change, both invalid cases are handled consistently and upfront.