Updated listStoragePools response - added new managed parameter by sureshanaparti · Pull Request #9588 · apache/cloudstack

sureshanaparti · 2024-08-26T08:19:35Z

Description

This PR updates listStoragePools response - added new managed parameter.

Partially addresses #8731

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually, tested the listStoragePools API.

How did you try to break this feature and the system with this change?

codecov · 2024-08-26T08:28:25Z

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (0597def) to head (cc7d786).
Report is 11 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...om/cloud/api/query/dao/StoragePoolJoinDaoImpl.java	0.00%	9 Missing ⚠️
...e/cloudstack/api/response/StoragePoolResponse.java	0.00%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9588      +/-   ##
============================================
- Coverage     15.08%   15.08%   -0.01%     
+ Complexity    11184    11183       -1     
============================================
  Files          5406     5406              
  Lines        472915   472930      +15     
  Branches      60040    58313    -1727     
============================================
- Hits          71345    71344       -1     
- Misses       393626   393644      +18     
+ Partials       7944     7942       -2

Flag	Coverage Δ
uitests	`4.30% <ø> (ø)`
unittests	`15.80% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti · 2024-08-26T08:28:58Z

@blueorangutan package

DaanHoogland

clgtm

sureshanaparti · 2024-08-28T09:04:04Z

server/src/main/java/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java

+                DataStore store = dataStoreMgr.getDataStore(pool.getId(), DataStoreRole.Primary);
+                PrimaryDataStoreDriver driver = (PrimaryDataStoreDriver) store.getDriver();
+                long usedIops = driver.getUsedIops(storagePool);
+                poolResponse.setAllocatedIops(usedIops);


this code is sync with the response parameters set for managed pools here:

cloudstack/server/src/main/java/com/cloud/api/query/dao/StoragePoolJoinDaoImpl.java

Lines 147 to 151 in 674129c

if (storagePool.isManaged()) {

DataStore store = dataStoreMgr.getDataStore(pool.getId(), DataStoreRole.Primary);

PrimaryDataStoreDriver driver = (PrimaryDataStoreDriver) store.getDriver();

long usedIops = driver.getUsedIops(storagePool);

poolResponse.setAllocatedIops(usedIops);

sureshanaparti · 2024-08-28T09:04:46Z

@blueorangutan package

blueorangutan · 2024-08-28T09:06:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-28T10:23:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10840

sureshanaparti · 2024-08-28T10:44:20Z

@blueorangutan test

blueorangutan · 2024-08-28T10:46:03Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-29T03:55:36Z

[SF] Trillian test result (tid-11217)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59495 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9588-t11217-kvm-ol8.zip
Smoke tests completed. 128 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_10_attachAndDetach_iso	`Failure`	816.90	test_vm_life_cycle.py
test_04_deploy_vnf_appliance	`Error`	92.71	test_vnf_templates.py
test_04_deploy_vnf_appliance	`Error`	92.71	test_vnf_templates.py
test_05_delete_vnf_template	`Error`	1.11	test_vnf_templates.py
ContextSuite context=TestVnfTemplates>:teardown	`Error`	1.20	test_vnf_templates.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	367.95	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	360.64	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	243.05	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	198.68	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	290.63	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	290.64	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	181.78	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	182.79	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	424.68	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	249.94	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	296.31	test_vpc_vpn.py

sureshanaparti · 2024-08-30T08:10:21Z

@blueorangutan package

blueorangutan · 2024-08-30T08:12:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-30T09:17:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10877

sureshanaparti · 2024-08-30T12:46:24Z

@blueorangutan test

blueorangutan · 2024-08-30T12:48:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-08-31T02:59:26Z

[SF] Trillian test result (tid-11260)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48865 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9588-t11260-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.38	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.39	test_vm_life_cycle.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	357.73	test_vpc_vpn.py

kiranchavala

LGTM

The managed parameter is present

Before fix


  "storagepool": [
    {
      "clusterid": "0b9e2379-183d-4e23-be39-2d3a9fc612eb",
      "clustername": "p1-c1",
      "created": "2024-09-02T06:04:41+0000",
      "disksizeallocated": 5295898792,
      "disksizetotal": 2197949513728,
      "disksizeused": 1587378388992,
      "hasannotations": false,
      "hypervisor": "KVM",
      "id": "373915ca-ac45-39e6-9d24-581ae842a6e1",
      "ipaddress": "10.0.32.4",
      "istagarule": false,
      "name": "ref-trl-7229-k-Mol8-kiran-chavala-kvm-pri1",
      "overprovisionfactor": "2.0",
      "path": "/acs/primary/ref-trl-7229-k-Mol8-kiran-chavala/ref-trl-7229-k-Mol8-kiran-chavala-kvm-pri1",
      "podid": "9ec8c022-f6e2-44e9-b5f0-4ba656ea8700",
      "podname": "Pod1",
      "provider": "DefaultPrimary",
      "scope": "CLUSTER",
      "state": "Up",
      "storagecapabilities": {
        "VOLUME_SNAPSHOT_QUIESCEVM": "false"
      },
      "type": "NetworkFilesystem",
      "zoneid": "1687b564-7058-4a75-8ef0-da2df838d7ee",
      "zonename": "ref-trl-7229-k-Mol8-kiran-chavala"
    },

After the fix "managed": false is present

      "storagepool": [
    {
      "clusterid": "9f9d0253-e541-463a-b49c-0b02f6488902",
      "clustername": "p1-c1",
      "created": "2024-09-03T06:26:51+0000",
      "disksizeallocated": 5243076688,
      "disksizetotal": 2197949513728,
      "disksizeused": 1611492491264,
      "hasannotations": false,
      "hypervisor": "KVM",
      "id": "8ff79807-6bac-39a0-9635-abc03ab5cf0a",
      "ipaddress": "10.0.32.4",
      "istagarule": false,
      "managed": false,
      "name": "ref-trl-7251-k-Mol8-kiran-chavala-kvm-pri1",
      "overprovisionfactor": "2.0",
      "path": "/acs/primary/ref-trl-7251-k-Mol8-kiran-chavala/ref-trl-7251-k-Mol8-kiran-chavala-kvm-pri1",
      "podid": "469b1380-385f-4581-9168-7eaa171061f5",
      "podname": "Pod1",
      "provider": "DefaultPrimary",
      "scope": "CLUSTER",
      "state": "Up",
      "storagecapabilities": {
        "VOLUME_SNAPSHOT_QUIESCEVM": "false"
      },
      "type": "NetworkFilesystem",
      "zoneid": "dda37f34-1922-4c31-b1b9-3daae26a24b2",
      "zonename": "ref-trl-7251-k-Mol8-kiran-chavala"
    },

…he#9588)

Updated listStoragePools response - added new managed parameter

cc7d786

boring-cyborg bot added the component:api label Aug 26, 2024

sureshanaparti mentioned this pull request Aug 26, 2024

listStoragePools return all fields #8731

Closed

sureshanaparti requested a review from vishesh92 August 26, 2024 08:29

sureshanaparti assigned DaanHoogland Aug 26, 2024

sureshanaparti requested a review from DaanHoogland August 26, 2024 08:29

sureshanaparti unassigned DaanHoogland Aug 26, 2024

DaanHoogland approved these changes Aug 26, 2024

View reviewed changes

sureshanaparti marked this pull request as ready for review August 28, 2024 08:59

sureshanaparti commented Aug 28, 2024

View reviewed changes

weizhouapache approved these changes Aug 30, 2024

View reviewed changes

kiranchavala approved these changes Sep 3, 2024

View reviewed changes

yadvr approved these changes Sep 4, 2024

View reviewed changes

yadvr added this to the 4.19.2.0 milestone Sep 4, 2024

yadvr merged commit b78aede into apache:4.19 Sep 4, 2024

yadvr deleted the list-storage-pools-response-improvements branch September 4, 2024 06:24

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024

Updated listStoragePools response - added new managed parameter (apac…

6c35122

…he#9588)

	if (storagePool.isManaged()) {
	DataStore store = dataStoreMgr.getDataStore(pool.getId(), DataStoreRole.Primary);
	PrimaryDataStoreDriver driver = (PrimaryDataStoreDriver) store.getDriver();
	long usedIops = driver.getUsedIops(storagePool);
	poolResponse.setAllocatedIops(usedIops);

Conversation

sureshanaparti commented Aug 26, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Aug 26, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Aug 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Aug 28, 2024

Uh oh!

blueorangutan commented Aug 28, 2024

Uh oh!

blueorangutan commented Aug 28, 2024

Uh oh!

sureshanaparti commented Aug 28, 2024

Uh oh!

blueorangutan commented Aug 28, 2024

Uh oh!

blueorangutan commented Aug 29, 2024

Uh oh!

sureshanaparti commented Aug 30, 2024

Uh oh!

blueorangutan commented Aug 30, 2024

Uh oh!

blueorangutan commented Aug 30, 2024

Uh oh!

sureshanaparti commented Aug 30, 2024

Uh oh!

blueorangutan commented Aug 30, 2024

Uh oh!

blueorangutan commented Aug 31, 2024

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Aug 26, 2024 •

edited

Loading

sureshanaparti Aug 28, 2024 •

edited

Loading