ui: show guest networks for guest vlans list

[shwstppr]

Description

Fixes #7247

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.08%. Comparing base (f0ba905) to head (06ec0f4).
Report is 24 commits behind head on 4.19.

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19    #9554      +/-   ##
============================================
+ Coverage     15.07%   15.08%   +0.01%     
- Complexity    11168    11185      +17     
============================================
  Files          5406     5406              
  Lines        472795   472908     +113     
  Branches      57834    58183     +349     
============================================
+ Hits          71282    71352      +70     
- Misses       393585   393612      +27     
- Partials       7928     7944      +16     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.80% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shwstppr]

@blueorangutan ui

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9554 (QA-JID-429)

[weizhouapache]

@shwstppr
code lgtm
have you tested user-shared networks ?

[shwstppr]

@weizhouapache I'm not sure but is there some backend issue with VLANs for shared networks?
While VLAN is assigned to the network, it still shows as Free in the VLANs list

Also, we maybe returning DB IDs in the listguestvlans API

[weizhouapache]

@weizhouapache I'm not sure but is there some backend issue with VLANs for shared networks? While VLAN is assigned to the network, it still shows as Free in the VLANs list

Also, we maybe returning DB IDs in the listguestvlans API

if create a shared network with specified vlan and skip vlan overlap check, the vlan will not be updated in table op_dc_vnet_alloc

to test user-shared network, you can

• create a network offering for shared network with specifyvlan=false
• create a shared network with the new network offering
• you need to specify an isolated (or L2) network with associated network (the two networks will use the same vlan).

when done, the guest networks tab will list both networks, for example

the table op_dc_vnet_alloc does not have column uuid so only id is returned and displayed on UI.
considering the api is only available for root admin, it might be a minor issue

[shwstppr]

@weizhouapache works fine

[weizhouapache]

@weizhouapache works fine

cool, thanks @shwstppr

[weizhouapache]

lgtm

[kiranchavala]

LGTM, the guest networks information is displayed on the vlan view