engine-schema,cks: fix finding non-removed network vms

[shwstppr]

Description

Fixes #9331

Only those VMs should be considered as network VMs which have a NIC entry that is not marked removed.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.05%. Comparing base (1218392) to head (79d5eb3).
Report is 31 commits behind head on 4.19.

Files	Patch %	Lines
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              4.19    #9339       +/-   ##
============================================
+ Coverage     4.27%   15.05%   +10.77%     
- Complexity       0    11133    +11133     
============================================
  Files          364     5405     +5041     
  Lines        29441   472355   +442914     
  Branches      5147    61136    +55989     
============================================
+ Hits          1260    71125    +69865     
- Misses       28038   393308   +365270     
- Partials       143     7922     +7779     

Flag	Coverage Δ
uitests	4.27% <ø> (-0.01%)	⬇️
unittests	15.77% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10257

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10804)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44080 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9339-t10804-kvm-centos7.zip
Smoke tests completed. 130 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_cancel_host_maintenace_with_migration_jobs	Error	219.80	test_host_maintenance.py
test_hostha_kvm_host_fencing	Error	108.32	test_hostha_kvm.py

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10352