server: allow migration of vm with snapshots for vmware

[shwstppr]

Description

Fixes #9061

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.16%. Comparing base (82396b6) to head (55f5cc2).
⚠️ Report is 72 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20    #9305   +/-   ##
=========================================
  Coverage     16.16%   16.16%           
- Complexity    13277    13278    +1     
=========================================
  Files          5656     5656           
  Lines        497880   497882    +2     
  Branches      60378    60379    +1     
=========================================
+ Hits          80462    80463    +1     
- Misses       408463   408464    +1     
  Partials       8955     8955           

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	17.01% <60.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10427

[weizhouapache]

code lgtm

not tested yet

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10434

[shwstppr]

@blueorangutan help

[blueorangutan]

@shwstppr [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'alma8', 'alma9', 'suse15', 'centos7', 'centos6', 'rocky8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar']

[shwstppr]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11237)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50717 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t11237-vmware-70u3.zip
Smoke tests completed. 135 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_06_purge_expunged_vm_background_task	Failure	344.84	test_purge_expunged_vms.py
test_02_restore_vm_with_disk_offering	Error	62.56	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	63.63	test_restore_vm.py

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10882

[shwstppr]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11278)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55622 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t11278-vmware-70u3.zip
Smoke tests completed. 137 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deployVMInSharedNetwork	Error	135.04	test_network.py
test_02_restore_vm_with_disk_offering	Error	56.21	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	62.42	test_restore_vm.py

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[yadvr]

LGTM didn't test it

[yadvr]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13189)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60287 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t13189-vmware-70u3.zip
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_events_resource	Error	333.20	test_events_resource.py
test_01_events_resource	Error	333.21	test_events_resource.py
test_04_deploy_vm_for_other_user_and_test_vm_operations	Error	112.75	test_network_permissions.py
test_01_deployVMInSharedNetwork	Error	162.69	test_network.py
test_02_restore_vm_with_disk_offering	Error	62.25	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	56.16	test_restore_vm.py
test_02_restore_vm_strict_tags_failure	Error	56.59	test_vm_strict_host_tags.py

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14859

[shwstppr]

@blueorangutan test ol8 vmware-70u3

[blueorangutan]

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14232)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57787 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9305-t14232-vmware-70u3.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	Error	1.53	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	Error	1.46	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	Error	1.34	test_scale_vm.py

[DaanHoogland]

@blueorangutan test ol9 vmware-80u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests

[weizhouapache]

Tested OK

• deploy vm
• create vm snapshot
• try to migrate vm with volumes (to another pool)

prior to this change

after this change: it worked