Skip to content

Conversation

@charlesweng
Copy link
Contributor

Description

This pull requests tests that we are able to get the next connected host in terms of the VM. This is important in making sure that a list of hosts.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

This test has been tested using the standard maven install lifecycle.

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.24%. Comparing base (2542582) to head (0a4f269).
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #9136       +/-   ##
============================================
- Coverage     15.28%   4.24%   -11.05%     
============================================
  Files          5424     364     -5060     
  Lines        474414   29736   -444678     
  Branches      60529    5222    -55307     
============================================
- Hits          72531    1263    -71268     
+ Misses       393818   28329   -365489     
+ Partials       8065     144     -7921     
Flag Coverage Δ
uitests 4.24% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland reopened this Jun 3, 2024
@charlesweng charlesweng force-pushed the add-agent-shell-next-host-test branch from 155d31e to 0a4f269 Compare June 7, 2024 19:55
@DaanHoogland DaanHoogland merged commit 6459357 into apache:main Jun 12, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants