Skip to content

Conversation

@winterhazel
Copy link
Member

Description

This PR changes the volume tab in the instance details page, the volume migration pop-up and the instance migration with volumes pop-up to show admins in which primary storage the volumes are allocated.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Volumes tab in the instance details page

Screenshot from 2024-03-26 09-43-58

Volume migration pop-up

Screenshot from 2024-03-26 09-44-51

Instance migration with volumes pop-up

Screenshot from 2024-03-26 09-45-26

How Has This Been Tested?

  1. In the root admin account, I accessed an instance's page and verified that the volumes tab showed the Storage column.
  2. In an account that did not have permission to view the storage a volume is allocated, I accessed an instance's page and verified that the volumes tab did not show the Storage column.
  3. In the root admin account, I opened the volume migration pop-up and verified that it showed the volume's current storage;
  4. In the root admin account, I opened the instance migration with volumes pop-up and verified that it showed the current storage volumes were allocated in.

@codecov
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 31.09%. Comparing base (e44c17e) to head (bfccff0).

Files Patch % Lines
ui/src/components/view/VolumesTab.vue 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8835      +/-   ##
============================================
+ Coverage     30.93%   31.09%   +0.15%     
- Complexity    33753    33955     +202     
============================================
  Files          5404     5404              
  Lines        380309   380312       +3     
  Branches      55507    55508       +1     
============================================
+ Hits         117658   118259     +601     
+ Misses       247041   246362     -679     
- Partials      15610    15691      +81     
Flag Coverage Δ
simulator-marvin-tests 24.85% <ø> (+0.29%) ⬆️
uitests 4.34% <0.00%> (-0.01%) ⬇️
unit-tests 16.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8835 (QA-JID-308)

Copy link
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I manually tested in the QA environment.

Volumes tab in VM details page:

Before

image

After

image

Volume migration modal:

Before

image

After

image

VM migration to another primary storage modal:

Before

image

After

image

@BryanMLima BryanMLima added this to the 4.20.0.0 milestone Jun 12, 2024
Copy link
Contributor

@BryanMLima BryanMLima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@DaanHoogland DaanHoogland merged commit 525c2c6 into apache:main Jun 13, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants