KVM Ingestion - Import Instance by kishankavala · Pull Request #7976 · apache/cloudstack

kishankavala · 2023-09-19T09:49:12Z

Description

This PR adds new functionality to import KVM instances from below sources:

KVM instance External host using libvirt
QCOW2 disk image in existing ACS local primary storage
QCOW2 disk image in existing ACS shared primary storage

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested Manually

codecov · 2023-09-19T10:19:05Z

Codecov Report

Attention: 934 lines in your changes are missing coverage. Please review.

Comparison is base (82f7abd) 28.91% compared to head (7441653) 28.96%.

Files	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	52.48%	150 Missing and 79 partials ⚠️
...er/LibvirtGetUnmanagedInstancesCommandWrapper.java	1.66%	118 Missing ⚠️
ui/src/views/tools/ManageInstances.vue	0.00%	111 Missing ⚠️
...rce/wrapper/LibvirtGetRemoteVmsCommandWrapper.java	2.17%	90 Missing ⚠️
...ypervisor/kvm/resource/LibvirtDomainXMLParser.java	23.72%	32 Missing and 13 partials ⚠️
ui/src/views/tools/ImportUnmanagedInstance.vue	0.00%	43 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java	0.00%	31 Missing ⚠️
...wrapper/LibvirtCopyRemoteVolumeCommandWrapper.java	6.25%	30 Missing ⚠️
...a/com/cloud/agent/api/CopyRemoteVolumeCommand.java	0.00%	27 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	0.00%	27 Missing ⚠️
... and 18 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #7976      +/-   ##
============================================
+ Coverage     28.91%   28.96%   +0.04%     
- Complexity    31419    31528     +109     
============================================
  Files          5329     5341      +12     
  Lines        373594   374759    +1165     
  Branches      54319    54510     +191     
============================================
+ Hits         108027   108547     +520     
- Misses       250807   251338     +531     
- Partials      14760    14874     +114

Flag	Coverage Δ
simulator-marvin-tests	`24.74% <0.93%> (+0.02%)`	⬆️
uitests	`4.40% <0.00%> (-0.03%)`	⬇️
unit-tests	`14.90% <30.53%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ImportVmCmd.java

api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListVmsForImportCmd.java

...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

core/src/main/java/com/cloud/agent/api/GetRemoteVmsAnswer.java

core/src/main/java/com/cloud/agent/api/GetRemoteVmsCommand.java

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

ui/src/views/compute/wizard/MultiNetworkSelection.vue

ui/src/views/tools/ImportUnmanagedInstance.vue

server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java

kiranchavala · 2023-10-09T12:21:05Z

@blueorangutan package

blueorangutan · 2023-10-09T12:22:03Z

@kiranchavala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-09T12:30:51Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7278

DaanHoogland · 2023-10-09T15:25:03Z

@blueorangutan package

blueorangutan · 2023-10-09T15:26:03Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-09T16:27:18Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7283

kiranchavala · 2023-10-10T05:36:10Z

@kishankavala

can you fix the packaging issue, getting the following exception

21:05:08 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-server: Compilation failure
21:05:08 [ERROR] /jenkins/workspace/acs-centos7-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.19.0.0-SNAPSHOT/server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:[1605,45] error: method getUnmanagedNicNetworkMap in class UnmanagedVMsManagerImpl cannot be applied to given types;
21:05:08 [ERROR]   required: String,List<Nic>,Map<String,Long>,Map<String,IpAddresses>,DataCenter,String,Account
21:05:08 [ERROR]   found: List<Nic>,Map<String,Long>,Map<String,IpAddresses>,DataCenter,String,Account
21:05:08 [ERROR]   reason: actual and formal argument lists differ in length
21:05:08 [ERROR]

harikrishna-patnala · 2023-10-10T11:09:56Z

@blueorangutan package

blueorangutan · 2023-10-10T11:12:04Z

@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-10T12:17:53Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7304

kishankavala · 2023-10-24T17:58:29Z

@blueorangutan package

blueorangutan · 2023-10-24T18:04:03Z

@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-24T18:40:16Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 7489

kishankavala · 2023-10-24T21:42:13Z

@blueorangutan package

blueorangutan · 2023-10-24T21:44:03Z

@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-10-24T22:39:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7491

github-actions · 2023-12-13T08:56:00Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

harikrishna-patnala · 2023-12-13T11:20:07Z

@blueorangutan package

blueorangutan · 2023-12-13T11:22:04Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

kishankavala · 2023-12-13T11:33:06Z

@blueorangutan package

blueorangutan · 2023-12-13T11:34:03Z

@kishankavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-12-13T12:25:06Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8041

blueorangutan · 2023-12-13T12:30:43Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8042

andrijapanicsb

LGTM, after detailed testing.

shwstppr · 2023-12-13T12:49:20Z

@blueorangutan test

blueorangutan · 2023-12-13T12:50:04Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-13T13:21:00Z

[SF] Trillian Build Failed (tid-8576)

shwstppr · 2023-12-13T13:51:13Z

@blueorangutan test

blueorangutan · 2023-12-13T13:52:04Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-13T14:23:15Z

[SF] Trillian Build Failed (tid-8577)

shwstppr · 2023-12-13T17:08:26Z

@blueorangutan test

blueorangutan · 2023-12-13T17:14:04Z

@shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-12-14T07:21:02Z

[SF] Trillian test result (tid-8579)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49322 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7976-t8579-kvm-centos7.zip
Smoke tests completed. 121 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

This PR adds new functionality to import KVM instances from an external host or from disk images in local or shared storage. Doc PR: apache/cloudstack-documentation#356

This PR fixes KVM manage/unmanage functionality on 4.19.0 RC1 - was introduced on #7976 but the latest merge commits on the PR removed the execution for KVM

This PR fixes KVM manage/unmanage functionality on 4.19.0 RC1 - was introduced on apache#7976 but the latest merge commits on the PR removed the execution for KVM

Added documentation for Import from External Host, Import from Local/Shared storage apache/cloudstack#7976

boring-cyborg bot added component:api component:kvm component:orchestration component:UI Python Warning... Python code Ahead! labels Sep 19, 2023

kishankavala marked this pull request as draft September 19, 2023 09:49

nvazquez reviewed Sep 27, 2023

View reviewed changes

DaanHoogland closed this Sep 29, 2023

DaanHoogland reopened this Sep 29, 2023

DaanHoogland added this to the 4.19.0.0 milestone Sep 29, 2023

DaanHoogland closed this Oct 9, 2023

DaanHoogland reopened this Oct 9, 2023

harikrishna-patnala force-pushed the kvm_ingestion branch from b964893 to b600bb9 Compare October 10, 2023 11:09

github-actions bot added the status:has-conflicts label Dec 13, 2023

Merge branch 'main' into kvm_ingestion

7441653

github-actions bot removed the status:has-conflicts label Dec 13, 2023

andrijapanicsb self-requested a review December 13, 2023 12:32

andrijapanicsb approved these changes Dec 13, 2023

View reviewed changes

shwstppr changed the title ~~[Draft] KVM Ingestion - Import Instance~~ KVM Ingestion - Import Instance Dec 13, 2023

shwstppr marked this pull request as ready for review December 13, 2023 12:35

shwstppr merged commit ab20b12 into apache:main Dec 14, 2023

weizhouapache mentioned this pull request Dec 14, 2023

Extend Import-Export Instances to the KVM Hypervisor #7127

Closed

nvazquez mentioned this pull request Jan 3, 2024

Fix KVM import unmanaged instance #8433

Merged

13 tasks

shwstppr pushed a commit that referenced this pull request Jan 9, 2024

Fix KVM import unmanaged instance (#8433)

9a915b1

This PR fixes KVM manage/unmanage functionality on 4.19.0 RC1 - was introduced on #7976 but the latest merge commits on the PR removed the execution for KVM

shwstppr pushed a commit to apache/cloudstack-documentation that referenced this pull request Feb 5, 2024

Docs for KVM Ingestion feature (#356)

c79d1d1

Added documentation for Import from External Host, Import from Local/Shared storage apache/cloudstack#7976

Conversation

kishankavala commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov bot commented Sep 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kiranchavala commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

DaanHoogland commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

blueorangutan commented Oct 9, 2023

Uh oh!

kiranchavala commented Oct 10, 2023

Uh oh!

harikrishna-patnala commented Oct 10, 2023

Uh oh!

blueorangutan commented Oct 10, 2023

Uh oh!

blueorangutan commented Oct 10, 2023

Uh oh!

kishankavala commented Oct 24, 2023

Uh oh!

blueorangutan commented Oct 24, 2023

Uh oh!

blueorangutan commented Oct 24, 2023

Uh oh!

kishankavala commented Oct 24, 2023

Uh oh!

blueorangutan commented Oct 24, 2023

Uh oh!

blueorangutan commented Oct 24, 2023

Uh oh!

github-actions bot commented Dec 13, 2023

Uh oh!

harikrishna-patnala commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

kishankavala commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

andrijapanicsb left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

blueorangutan commented Dec 13, 2023

Uh oh!

kishankavala commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading