[AGENT] host os accepted if only the first word is defined for the cluster

[DaanHoogland]

Description

This PR...

Fixes: #7616

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

@weizhouapache , architecturally I don't whink this is the best solution but it will allow running environments to keep running. I don't know of an example where two different OSses use the same first word in their name, but if that exists, this won't work (i think for our Rocky and Red instances it will work).

[weizhouapache]

@weizhouapache , architecturally I don't whink this is the best solution but it will allow running environments to keep running. I don't know of an example where two different OSses use the same first word in their name, but if that exists, this won't work (i think for our Rocky and Red instances it will work).

@DaanHoogland
this might work, at least restarting cloudstack-agent should.
when all cloudstack-agent are started, all agent should have the correct Host.OS in host_details

I will test it

another option might be updating existing Host.OS in host_details (mostly rocky/rhel). is alma impacted?

[DaanHoogland]

I will test it

thanks

another option might be updating existing Host.OS in host_details (mostly rocky/rhel). is alma impacted?

I was thinking of that as well, but we cannot be sure to be complete and correct with this strategy. Rocky and Red make us make assumptions that might not be correct and as you mentioned, I forgot about Alma. This is not a problem btw as it is called "AlmaLinux".

To be sure we would need to check every possible host type that is supported and query "Host.OS" from the host_details tables. Can we be sure about the limits of this?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [LL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Merging #7620 (64fe13d) into 4.18 (0d3ac9f) will increase coverage by 0.00%.
The diff coverage is 48.14%.

@@            Coverage Diff            @@
##               4.18    #7620   +/-   ##
=========================================
  Coverage     12.98%   12.98%           
- Complexity     8984     8989    +5     
=========================================
  Files          2716     2716           
  Lines        256329   256343   +14     
  Branches      39974    39981    +7     
=========================================
+ Hits          33275    33291   +16     
+ Misses       218892   218885    -7     
- Partials       4162     4167    +5     

Impacted Files	Coverage Δ
...rvisor/kvm/discoverer/LibvirtServerDiscoverer.java	0.00% <0.00%> (ø)
.../secondarystorage/SecondaryStorageManagerImpl.java	6.58% <56.52%> (+1.97%)	⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Packaging result [LL]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6130

[borisstoyanov]

@blueorangutan test keepEnv

[blueorangutan]

@borisstoyanov a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[weizhouapache]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[weizhouapache]

code lgtm

[blueorangutan]

[SF] Trillian test result (tid-6738)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44799 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7620-t6738-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	Error	77.65	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	Error	51.30	test_vm_life_cycle.py

[blueorangutan]

[SF] Trillian test result (tid-6739)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48128 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7620-t6739-kvm-rocky8.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[harikrishna-patnala]

LGTM.

Tried looking for other possible solutions, but this seems to be fair with the existing list of OSes I can think of.

[borisstoyanov]

LGTM