Improve cloud-install-sys-tmplt to work in dev environment again#678
Merged
asfgit merged 3 commits intoapache:masterfrom Aug 11, 2015
Merged
Conversation
In dev environments, there is no /etc/cloudstack/management/db.properties file That forces you to specify all parameters on the command line. This commit sets some defaults, like port 3306, user root and localhost. When available, it will still get settings from the config file and it will also allow you to override it on the command line. So it is fully backwards compatible.
- replace tabs with 4 spaces - removed trailing spaces - fixed indenting - made if; then look the same
|
cloudstack-pull-rats #258 SUCCESS |
|
cloudstack-pull-requests #955 SUCCESS |
|
cloudstack-pull-analysis #191 ABORTED |
|
lgtm, tested and uploads without the file there now. |
Contributor
|
lgtm |
asfgit
pushed a commit
that referenced
this pull request
Aug 11, 2015
…t-port Improve cloud-install-sys-tmplt to work in dev environment againThe script that you run to initially setup secondary storage, had some errors. As it now depends on /etc/cloudstack/management/db.properties, it did not work any more on my development environment. I defined some defaults that work in development environments (those are sane defaults anyway), then check if the /etc/cloudstack/management/db.properties file exists. If so, it reads from there and gets the vars just like before. If not, it keeps the defaults unless of course someone overrides them on the command line. While working on the script, I also fixed the indentation and found a query that was not yet using the -P mysql port variable. I tested it both on my development environment as well as in an environment installed from RPM (where you'd have /etc/cloudstack/management/db.properties and that both worked. PS @snuf please check if it also works again for you. * pr/678: clean-ups in the file this query had no -P port specified so did not work make sane defaults for MySQL settings Signed-off-by: Remi Bergsma <github@remi.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script that you run to initially setup secondary storage, had some errors. As it now depends on /etc/cloudstack/management/db.properties, it did not work any more on my development environment.
I defined some defaults that work in development environments (those are sane defaults anyway), then check if the /etc/cloudstack/management/db.properties file exists. If so, it reads from there and gets the vars just like before. If not, it keeps the defaults unless of course someone overrides them on the command line.
While working on the script, I also fixed the indentation and found a query that was not yet using the -P mysql port variable.
I tested it both on my development environment as well as in an environment installed from RPM (where you'd have /etc/cloudstack/management/db.properties and that both worked.
PS @snuf please check if it also works again for you.