Skip to content

Added a test to verify that listSnapshots response returns zone id#632

Closed
manasaveloori wants to merge 2 commits intoapache:masterfrom
manasaveloori:Local
Closed

Added a test to verify that listSnapshots response returns zone id#632
manasaveloori wants to merge 2 commits intoapache:masterfrom
manasaveloori:Local

Conversation

@manasaveloori
Copy link
Contributor

@manasaveloori manasaveloori commented Jul 29, 2015

Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk | Status : SUCCESS ===
ok

Ran 1 test in 339.130s

OK

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jul 29, 2015

@manasaveloori can you give us the command to which this output fits?

@gauravaradhye can you review this, please? (looks like a lot of code to me)

@manasaveloori
Copy link
Contributor Author

manasaveloori commented Jul 29, 2015

@DaanHoogland
This is just an enhancement to existing test in the script.
The output is from nose test result of the script.

gauravaradhye
gauravaradhye reviewed Jul 29, 2015
View reviewed changes
test/integration/smoke/test_snapshots.py Outdated
Copy link

@gauravaradhye gauravaradhye Jul 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can directly use assertIsNotNone here.

@gauravaradhye
Copy link

gauravaradhye commented Jul 29, 2015

LGTM except one small change suggested.
Please don't mix intended changes and pep8 fixes, you can add another review request for pep8 fixes subsequently. That will remove the confusion while reviewing.

@asfbot
Copy link

asfbot commented Jul 29, 2015

cloudstack-pull-rats #144 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

cloudstack-pull-requests #842 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

cloudstack-pull-analysis #77 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

cloudstack-pull-rats #148 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

cloudstack-pull-requests #846 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 29, 2015

cloudstack-pull-analysis #81 SUCCESS
This pull request looks good

@asfgit asfgit closed this in f45548b Jul 30, 2015
maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
@manasaveloori
Added a test to verify that listSnapshots response returns zone id
14ac65b 
Made changes based on Comments
This closes apache#632
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
Fixing calling templatefilter=all (#632)
895114b 
Fixes #605

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@manasaveloori @DaanHoogland @gauravaradhye @asfbot @sanju1010