Skip to content

Conversation

@pdion891
Copy link
Contributor

Initial PR for Dockerization of CloudStack.

Important Changes:

  • scripts/vm/systemvm/injectkeys.sh: script execution will pass event if /dev/loop0 not detected and will skip verification of sshkey, this is a limiation in Docker container.
  • Dockerfile for simulator move into /tools/docker: Need to change Jenkins jobs and Dockerhub build after the merge.

Current docker file working:

  • simulator (Seb's original file)
  • management-server on centos6 (using RPM's)
  • marvin

comments from PR #605 corrected.

1. update injectkeys.sh to work into restricted container
2. move previous dockerfiles into tools/docker
3. dockerfiles for management-server on centos and marvin

CLOUDSTACK-8249
@asfbot
Copy link

asfbot commented Jul 26, 2015

cloudstack-pull-rats #123 FAILURE
Looks like there's a problem with this pull request

@asfbot
Copy link

asfbot commented Jul 26, 2015

cloudstack-pull-requests #821 SUCCESS
This pull request looks good

@asfbot
Copy link

asfbot commented Jul 26, 2015

cloudstack-pull-analysis #56 UNSTABLE
Looks like there's a problem with this pull request

@wido
Copy link
Contributor

wido commented Jul 27, 2015

LGTM

@asfbot
Copy link

asfbot commented Jul 30, 2015

Pierre-Luc Dion on dev@cloudstack.apache.org replies:
Hello dev@!

I'm looking for another LGTM (real one, please read the PR) as replacement
of Seb, PR #623 replace the PR #605 based on Seb's comments.

Cheers,

@karuturi
Copy link
Member

I was able to build the images locally. changes looks good. 👍

for the centos 6 and marvin, it is always taking 4.6 images from jenkins. Which means we have to change this file for every release. Is there a way to get the current working release and probably release -1? If we could tag the master as latest and release-1 with the release number, that would be great.

@pdion891
Copy link
Contributor Author

pdion891 commented Aug 1, 2015

@karuturi , I haven't found a way to specify the release number at the docker build. If there is a way I would use it so Dockerfiles would be same across branches.

@asfgit asfgit closed this in 2ae2aac Aug 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants