Skip to content

Conversation

@Pearl1594
Copy link
Contributor

Description

This PR fixes the value set for minreq.sysvmtemplate.version when upgrading to 4.17. Because of the value being hard-coded to 4.16.0 at https://github.com/apache/cloudstack/blob/main/engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41610to41700.java#L73 it doesn't pick the right value, i.e., 4.16.1

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Upgrade from 4.16 to 4.17 and validate the global setting minreq.sysvmtemplate.version value

@Pearl1594 Pearl1594 requested a review from nvazquez April 7, 2022 09:50
@Pearl1594 Pearl1594 added this to the 4.17.0.0 milestone Apr 7, 2022
@Pearl1594 Pearl1594 requested a review from shwstppr April 7, 2022 10:11
@nvazquez
Copy link
Contributor

nvazquez commented Apr 7, 2022

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3095

@nvazquez
Copy link
Contributor

nvazquez commented Apr 7, 2022

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3840)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33094 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6227-t3840-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@nvazquez nvazquez merged commit daa7bdb into apache:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants