Conversation
|
cloudstack-pull-rats #106 SUCCESS |
|
cloudstack-pull-requests #804 UNSTABLE |
There was a problem hiding this comment.
Can you please update the error message: "Provided Metadata is not a URL, Unable to locate metadata file from local path"
There was a problem hiding this comment.
Can you also add the file path its trying to find (idpMetaDataUrl) to the error message?
|
cloudstack-pull-analysis #39 UNSTABLE |
|
cloudstack-pull-rats #111 SUCCESS |
|
cloudstack-pull-rats #112 SUCCESS |
|
cloudstack-pull-requests #809 UNSTABLE |
|
cloudstack-pull-requests #810 SUCCESS |
|
thanks @kansal |
|
@kishankavala: The message has been changed. I have also made another change with respect to solving this problem of dereferencing of null pointer. Kindly review the changes. |
|
cloudstack-pull-analysis #44 SUCCESS |
|
cloudstack-pull-analysis #45 ABORTED |
|
instead of a notnull check everywhere, can you use a Non Nulllable ArrayList for tags or use CollectionUtils.addIgnoreNull() api? |
|
@DaanHoogland Added the test file. Checking only the false cases. @wilderrodrigues Got away with the IF statements and replaced with the api @karuturi suggested. Please review the changes. |
|
cloudstack-pull-rats #127 FAILURE |
|
cloudstack-pull-requests #825 FAILURE |
|
cloudstack-pull-analysis #60 FAILURE |
|
cloudstack-pull-rats #128 SUCCESS |
|
cloudstack-pull-requests #826 SUCCESS |
|
LGTM. @bhaisaab can you also take a look at the changes? |
|
cloudstack-pull-analysis #61 SUCCESS |
|
LGTM 👍 Thanks for the improvements! |
There was a problem hiding this comment.
we can remove else {} here just keep;
if (condition){
return stuff();
}
return otherstuff();
There was a problem hiding this comment.
@bhaisaab I feel we can go with the if-else style because it anyhow is doing the same thing plus it give better code readability and logging. Your take?
|
@kansal Please see my comments. While it's okay, please squash the commits into two separate commits; one targeting the saml related stuff and second one targeting the other component, so as to allow us to port the commits to other branches. |
|
Closing this pull request. Will open one for each issue. |
Fixes #618 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
7 participants
No check on the null value of metadatafile. If null, the following operations failed. Added null check for the metadatafile.