[marvin, VMware] Fix repeated test failures observed on 'main' branch #5992

Pearl1594 · 2022-02-14T08:25:32Z

Description

This PR fixes the test failure observed on main branch for test_06_disk_offering_strictness_false
The main reason for the failure, is that the volume fails to resize on change of service offering reporting that the volume has a parent.

022-02-14 07:22:01,410 ERROR [c.c.h.v.r.VmwareResource] (DirectAgent-80:ctx-df1ac830 10.0.34.173, job-59/job-60, cmd: ResizeVolumeCommand) (logid:02e59892) Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].
2022-02-14 07:22:01,410 ERROR [c.c.h.v.r.VmwareResource] (DirectAgent-80:ctx-df1ac830 10.0.34.173, job-59/job-60, cmd: ResizeVolumeCommand) (logid:02e59892) Failed to resize volume of VM [name: i-6-7-VM] due to: [Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].].
java.lang.Exception: Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].
        at com.cloud.hypervisor.vmware.resource.VmwareResource.getDiskAfterResizeDiskValidations(VmwareResource.java:951)
        at com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:878)
        at com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:569)
        at com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
        at java.base/java.lang.Thread.run(Thread.java:829)

For resizing volumes in VMware it is required that vmware.create.full.clone be true. Hence, the test has been modified to set it to true at the start of the test and reset it back on completion.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

…on 'main' branch

Pearl1594 · 2022-02-14T08:38:38Z

@blueorangutan package

blueorangutan · 2022-02-14T08:39:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-14T09:15:46Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2598

Pearl1594 · 2022-02-14T09:42:32Z

@blueorangutan test matrix

blueorangutan · 2022-02-14T09:43:03Z

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-02-14T19:57:44Z

Trillian test result (tid-3324)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35504 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3324-kvm-centos7.zip
Smoke tests completed. 88 look OK, 4 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.69	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.11	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.18	test_primary_storage.py
test_01_secure_vm_migration	`Error`	159.95	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	270.58	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	143.19	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	43.89	test_vm_life_cycle.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.62	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.62	test_snapshots.py
test_hostha_kvm_host_degraded	`Error`	701.92	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	681.44	test_hostha_kvm.py

blueorangutan · 2022-02-14T20:08:17Z

Trillian test result (tid-3325)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36377 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3325-vmware-65u2.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_offline_migrate_VM_and_root_volume	`Error`	91.84	test_vm_life_cycle.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	65.47	test_vm_life_cycle.py

nvazquez · 2022-02-14T21:32:24Z

Thanks @Pearl1594 do you think you can include further fixes for the 2 failing tests on this PR or prefer to create a separate PR?

Pearl1594 · 2022-02-15T03:00:34Z

@blueorangutan package

blueorangutan · 2022-02-15T03:01:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T03:53:15Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2604

Pearl1594 · 2022-02-15T03:55:12Z

@blueorangutan test matrix

blueorangutan · 2022-02-15T03:56:02Z

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

test/integration/smoke/test_service_offerings.py

Pearl1594 · 2022-02-15T11:42:03Z

@blueorangutan package

blueorangutan · 2022-02-15T13:56:08Z

Trillian test result (tid-3331)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34568 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3331-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_disable_oobm_ha_state_ineligible	`Error`	1512.42	test_hostha_kvm.py

blueorangutan · 2022-02-15T17:05:43Z

Trillian test result (tid-3332)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46182 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3332-vmware-65u2.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	3605.56	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	3602.65	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	0.08	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.06	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	52.48	test_kubernetes_clusters.py

Pearl1594 · 2022-02-15T17:07:54Z

@blueorangutan package

blueorangutan · 2022-02-15T17:09:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T17:44:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2624

blueorangutan · 2022-02-15T19:57:20Z

Trillian test result (tid-3330)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56360 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3330-xenserver-71.zip
Smoke tests completed. 89 look OK, 3 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_06_download_detached_volume	`Error`	491.72	test_volumes.py
ContextSuite context=TestVolumes>:teardown	`Error`	73.51	test_volumes.py
test_deploy_vm_from_iso	`Error`	1513.29	test_deploy_vm_iso.py
test_02_upgrade_kubernetes_cluster	`Failure`	3611.83	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	60.48	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	0.07	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	0.05	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	1.11	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	0.10	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.08	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	95.18	test_kubernetes_clusters.py

Pearl1594 · 2022-02-16T05:15:16Z

@blueorangutan test matrix

blueorangutan · 2022-02-16T05:16:03Z

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-02-16T14:56:25Z

Trillian test result (tid-3360)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33565 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3360-xenserver-71.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-02-16T15:00:41Z

Trillian test result (tid-3361)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33701 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3361-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-02-16T15:30:55Z

Trillian test result (tid-3362)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35695 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5992-t3362-vmware-65u2.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez

LGTM thanks @Pearl1594

[marvin, VMware] Fix test_06_disk_offering_strictness_false observed …

a96bc13

…on 'main' branch

Pearl1594 requested review from harikrishna-patnala, nvazquez and sureshanaparti February 14, 2022 08:25

Pearl1594 added this to the 4.17.0.0 milestone Feb 14, 2022

Fix test

73fb707

Pearl1594 changed the title ~~[marvin, VMware] Fix test_06_disk_offering_strictness_false observed on 'main' branch~~ [marvin, VMware] Fix repeated test failures observed on 'main' branch Feb 15, 2022

sureshanaparti reviewed Feb 15, 2022

View reviewed changes

test/integration/smoke/test_service_offerings.py Outdated Show resolved Hide resolved

update config only if false

3ad8316

Pearl1594 added the component:marvin label Feb 15, 2022

sureshanaparti reviewed Feb 15, 2022

View reviewed changes

test/integration/smoke/test_service_offerings.py Outdated Show resolved Hide resolved

sureshanaparti reviewed Feb 15, 2022

View reviewed changes

test/integration/smoke/test_service_offerings.py Outdated Show resolved Hide resolved

sureshanaparti assigned Pearl1594 Feb 15, 2022

nvazquez reviewed Feb 15, 2022

View reviewed changes

test/integration/smoke/test_service_offerings.py Show resolved Hide resolved

reset full clone setting to original values

71e7b01

Pearl1594 requested a review from sureshanaparti February 15, 2022 11:42

Pearl1594 requested a review from nvazquez February 15, 2022 11:42

nvazquez approved these changes Feb 16, 2022

View reviewed changes

DaanHoogland approved these changes Feb 16, 2022

View reviewed changes

nvazquez merged commit ee947e1 into apache:main Feb 16, 2022

kiranchavala mentioned this pull request Mar 29, 2023

Fix ScaleVM to consider resize volume in any type of service offering #7359

Merged

12 tasks

[marvin, VMware] Fix repeated test failures observed on 'main' branch #5992

[marvin, VMware] Fix repeated test failures observed on 'main' branch #5992

Uh oh!

Conversation

Pearl1594 commented Feb 14, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Pearl1594 commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

Pearl1594 commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

blueorangutan commented Feb 14, 2022

Uh oh!

nvazquez commented Feb 14, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 16, 2022

Uh oh!

blueorangutan commented Feb 16, 2022

Uh oh!

blueorangutan commented Feb 16, 2022

Uh oh!

blueorangutan commented Feb 16, 2022

Uh oh!

blueorangutan commented Feb 16, 2022

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants