CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_doma… #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cloudstack-pull-rats #59 SUCCESS |
|
cloudstack-pull-requests #756 SUCCESS |
Contributor
|
I browsed the code and found out that this "templateSize = int(int(templates[0].size) / (1024**3))" was already been used in other places. So, your changes does make sense to me and therefore you get a LGTM 👍 Cheers, |
Contributor
|
LGTM (we could decide to make this a generic macro type of construct so we guarantee unified behavior. on the other hand this is not building a rocket...) |
maneesha-p
pushed a commit
to maneesha-p/cloudstack
that referenced
this pull request
Jul 31, 2015
…in_limits.py This closes apache#595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test result
Test secondary storage limit of domain and its sub-domains ... === TestName: test_04_create_template_delete_account | Status : SUCCESS ===
ok
Ran 1 test in 175.563s
OK