Skip to content

some component tests fixes #5442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2022
Merged

some component tests fixes #5442

merged 3 commits into from
Jun 10, 2022

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Sep 13, 2021 •
edited
Loading

Description

This PR is a continuation of work in #5082. aiming to have a full set of component tests running on all hypervisors. see #6391 for an inventory of all work to be done.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

included:

  • test_host_ha.py
  • test_rootvolume_resize.py
  • test_vpc_vm_life_cycle.py

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland DaanHoogland force-pushed the py3-component-tests-fixes branch from 6c702c2 to a205d92 Compare September 13, 2021 10:04
@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1244

@pdion891 pdion891 self-requested a review September 23, 2021 13:53
@DaanHoogland DaanHoogland force-pushed the py3-component-tests-fixes branch from a205d92 to 8550022 Compare October 4, 2021 08:18
@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1494

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Apr 6, 2022
@DaanHoogland DaanHoogland mentioned this pull request May 16, 2022
Open
58 tasks
@DaanHoogland DaanHoogland changed the title Py3 component tests fixes some component tests fixes May 16, 2022
@DaanHoogland DaanHoogland marked this pull request as ready for review May 16, 2022 09:04
rohityadavcloud
rohityadavcloud reviewed May 17, 2022
View reviewed changes
test/integration/component/test_host_ha.py

class TestHostHA(cloudstackTestCase):

hostCountMsg = "Host HA can be tested with at least two hosts, only %s found"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related but - isn't this VM HA? (not host HA with ipmi etc?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no? this is test_host_ha, is it?

Copy link
Member

@rohityadavcloud rohityadavcloud May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not I'm asking even though file says test_host_ha.py, are the tests for Host HA (or VM HA) that uses oobm/ipmi etc? Nevermind I'll check this myself.

Tests are host ha indeed!

@nvazquez nvazquez added this to the 4.18.0.0 milestone Jun 3, 2022
@DaanHoogland DaanHoogland changed the base branch from main to 4.17 June 8, 2022 11:56
@nvazquez
Copy link
Contributor

nvazquez commented Jun 8, 2022

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez nvazquez modified the milestones: 4.18.0.0, 4.17.1.0 Jun 8, 2022
@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3544

nvazquez
nvazquez reviewed Jun 9, 2022
View reviewed changes
test/integration/broken/test_vpc_vm_life_cycle.py


class TestVMLifeCycleSharedNwVPC(cloudstackTesTODOtCase):
class TestVMLifeCycleSharedNwVPC(cloudstackTestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file ready to be moved out of the 'broken' directory?

nvazquez
nvazquez approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - component tests passing on Travis

@nvazquez nvazquez merged commit bfe1697 into apache:4.17 Jun 10, 2022
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Jun 15, 2022
@DaanHoogland @Pearl1594
some component tests fixes (apache#5442)
e47b38b 
* allow 3 hosts or more

* make numbering consistent

* stray TODO removed

Co-authored-by: Daan Hoogland <dahn@onecht.net>
utchoang pushed a commit that referenced this pull request Jun 16, 2022
Revert "some component tests fixes (#5442)"
98bc441 
This reverts commit bfe1697.
sureshanaparti pushed a commit to shapeblue/cloudstack that referenced this pull request Jun 21, 2022
@sureshanaparti
Revert "some component tests fixes (apache#5442)"
4f3f0f5 
This reverts commit bfe1697.
rp- pushed a commit to LINBIT/cloudstack that referenced this pull request Jun 21, 2022
@rp-
Revert "some component tests fixes (apache#5442)"
3cdc728 
This reverts commit bfe1697.
GutoVeronezi pushed a commit to scclouds/cloudstack that referenced this pull request Jun 23, 2022
Revert "some component tests fixes (apache#5442)"
9778919 
This reverts commit bfe1697.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@nvazquez nvazquez nvazquez approved these changes

@pdion891 pdion891 Awaiting requested review from pdion891

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@DaanHoogland @blueorangutan @nvazquez @rohityadavcloud