UI - Scale VM - Fix compute offering selection not working

[utchoang]

Description

Fixes #5391

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[utchoang]

@blueorangutan ui

[blueorangutan]

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5392 (SL-JID-579)

[yadvr]

@blueorangutan ui

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5392 (SL-JID-580)

[davidjumani]

@utchoang I think another issue is the cpu speed slider is not being shown. Can you look into that? Can check if it needs to be shown if cpuspeed not in the response

[kricud]

@utchoang There is such field in legacy UI. It’s needed as its mandatory in offering. It would be grate that this field is prefilled, and admin can control default/prefilled value. Now for every new user trying to use this ticket is created with question what I must enter in CPU (in MHz) field.

[utchoang]

@davidjumani In my opinion, it would make more sense to not display the slider here anymore. What do you think?

[utchoang]

@kricud I don't know but what does your problem have to do with the slider not working?

[davidjumani]

@utchoang Yes, I think the slider is pointless unless it is a constrained offering (show it only for values within a range of cpu / memory and let the speed be a regular field) cc @rhtyd

[utchoang]

@blueorangutan ui

[blueorangutan]

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5392 (SL-JID-588)

[utchoang]

@blueorangutan ui

[blueorangutan]

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5392 (SL-JID-589)

[utchoang]

@blueorangutan ui

[kricud]

@utchoang
In Legacy UI if you want to use custom offering you need to enter/fill 3 values
CPU (in MHz), # of CPU Cores, Memory (in MB) they are mandatory.

In New UI you can enter only 2 values CPU Cores, Memory (in MB).
If you want to create service offering manually or dynamically you need to specify
CPU (in MHz) in both cases its mandatory field.

New UI is missing CPU (in MHz).

My two cents:
New UI sliders in their existing form are pointless:
For RAM slider you would expect increments in 1024MB.
For CPU Cores you would expect averaged maximum of host vCPU.
For CPU MHz you would expect all host MHz options.
I would suggest remove sliders if only things they do is increase number from 1 to something.

New UI:

Legacy UI:

Static offering:

[blueorangutan]

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5392 (SL-JID-590)

[shwstppr]

@kricud Is Custom compute offering - A a constrained custom offering or an unconstrained offering
In my test for this PR, UI seems to be showing correct fields for both constrained and unconstrained compute offerings.
No sliders for unconstrained custom offering

Sliders for constrained custom offering

Regarding max value for sliders, they are based on the max value set in the compute offering at the time of the creation. I don't think we need to involve host CPU/memory here.
Although the step for slider can be tweaked based on the min-max if it is not done already.

[kricud]

@shwstppr @utchoang My fail - operating with constrained offerings and raging on keyboard why its not doing what I’m expecting. Apologies for BS typing.

[kricud]

@shwstppr @utchoang Now it all came together- in our case its constrained offering that has no constrains.
It was created on 4.11.3 after migration to 4.15.1 its all bugging as it has missing mandatory values.

Name Custom compute offering - A
ID 5adb6fde-60e6-4bd1-b8ab-d48dae8f5fa0
Description Custom compute offering - A
Storage Type shared
Provisioning Type thin
Write-cache Type
of CPU Cores
CPU (in MHz)
Memory (in MB)
Network Rate (Mb/s) 1000
Custom IOPS
Min IOPS N/A
Max IOPS N/A
Hypervisor Snapshot Reserve N/A
Disk Read Rate (BPS)
Disk Write Rate (BPS)
Disk Read Rate (IOPS)
Disk Write Rate (IOPS)
Offer HA Yes
CPU Cap No
Volatile No
Deployment planner
Planner mode
GPU
vGPU type
Storage Tags
Host Tag
Domain ROOT
Zone
Created 08 Dec 2020 13:27:46

Apologies once more.

[shwstppr]

@kricud No problem.
I think the concept of constrained-unconstrained custom compute offerings got introduced in 4.14. Maybe there could be an issue with how custom compute offerings created prior to that were handled. Will try to check with a 4.11 to 4.14/4.15 upgrade.

[shwstppr]

LGTM. Checked different users of ComputeSelection.vue and ScaleVM form

[nvazquez]

LGTM