Skip to content

compatibility fix for Packer v1.7.4, update debian template to 10.10.0#5304

Merged
yadvr merged 1 commit intoapache:4.15from
pdion891:4.15-deb10
Aug 16, 2021
Merged

compatibility fix for Packer v1.7.4, update debian template to 10.10.0#5304
yadvr merged 1 commit intoapache:4.15from
pdion891:4.15-deb10

Conversation

@pdion891
Copy link
Contributor

Description

Update version of Debian iso to 10.10.0 which is the latest available version.
Fix the template.json file to be compatible with recent version of packer, tested on Packer v1.7.4; file generated from packer fix template.json command

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

systemvm template build tested in our internal CI-CD. Possible this is a breaking change on non updated packer build system.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 855

@Pearl1594
Copy link
Contributor

Pearl1594 commented Aug 12, 2021

Changes LGTM - on upgrading packer to v1.7.4, systemvm template build went through successfully. I have tested debian 10.10 with 6d37af8#diff-3e19610f126c120919f7ad68fff2a857527883a0c8649b76415a361ad42b5051R46 and it tested well. Will test this against 4.15 as well.

@blueorangutan
Copy link

Trillian test result (tid-1619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45097 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5304-t1619-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true Failure 305.81 test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false Failure 307.73 test_routers_network_ops.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers Failure 422.80 test_vpc_redundant.py

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tests were run on an env deployed with the new systemvm template. We could probably add a note for users to upgrade packer.

@yadvr yadvr added this to the 4.15.2.0 milestone Aug 16, 2021
@yadvr yadvr merged commit 1c29163 into apache:4.15 Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants