tests: Extend wait time after interrupt by davidjumani · Pull Request #4815 · apache/cloudstack

davidjumani · 2021-03-15T05:42:26Z

Description

This PR increases the timeout after interrupting a thread in the ConstantTimeBackoffTest.waitBeforeRetryWithInterrupt test, preventing intermittent failures especially in build envs with limited resources

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

Builds fail for some other reason

davidjumani · 2021-03-15T05:42:36Z

@blueorangutan package

blueorangutan · 2021-03-15T05:46:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-15T06:19:47Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 110

davidjumani · 2021-03-15T06:32:12Z

@blueorangutan package

blueorangutan · 2021-03-15T06:33:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-15T07:20:24Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 112

davidjumani · 2021-03-15T07:20:44Z

@blueorangutan package

blueorangutan · 2021-03-15T07:21:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-15T08:01:30Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 113

davidjumani · 2021-03-15T08:18:34Z

@blueorangutan package

blueorangutan · 2021-03-15T08:19:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-15T08:22:19Z

Packaging result: ✖️ centos7 ✖️ centos8 ✖️ debian. SL-JID 115

davidjumani · 2021-03-15T08:51:25Z

@blueorangutan package

blueorangutan · 2021-03-15T08:52:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-15T10:39:10Z

Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 119

blueorangutan · 2021-03-16T04:29:50Z

Packaging result: ✖️ centos7 ✖️ centos8 ✔️ debian. SL-JID 126

blueorangutan · 2021-03-16T04:54:12Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 127

davidjumani · 2021-03-16T05:20:44Z

@blueorangutan package

blueorangutan · 2021-03-16T05:23:29Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-16T05:58:22Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 128

davidjumani · 2021-03-16T08:50:44Z

@blueorangutan package

blueorangutan · 2021-03-16T08:52:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

davidjumani · 2021-03-17T05:05:17Z

@blueorangutan package

blueorangutan · 2021-03-17T05:06:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-17T05:31:27Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 142

davidjumani · 2021-03-17T05:32:21Z

@blueorangutan package

blueorangutan · 2021-03-17T05:33:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-17T05:57:14Z

Packaging result: ✔️ centos7 ✖️ centos8 ✖️ debian. SL-JID 143

davidjumani · 2021-03-17T06:05:34Z

@blueorangutan package

blueorangutan · 2021-03-17T06:06:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java

davidjumani · 2021-03-19T04:07:57Z

@blueorangutan package

blueorangutan · 2021-03-19T04:09:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-19T04:13:51Z

Packaging result: ✖️ centos7 ✖️ centos8 ✖️ debian. SL-JID 173

davidjumani · 2021-03-19T04:22:29Z

@blueorangutan package

blueorangutan · 2021-03-19T04:23:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-19T04:26:22Z

Packaging result: ✖️ centos7 ✖️ centos8 ✖️ debian. SL-JID 174

…ackoffTest.java Co-authored-by: dahn <daan.hoogland@gmail.com>

davidjumani · 2021-03-19T04:36:01Z

@blueorangutan package

blueorangutan · 2021-03-19T04:37:03Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-19T04:40:06Z

Packaging result: ✖️ centos7 ✖️ centos8 ✖️ debian. SL-JID 175

blueorangutan · 2021-03-19T05:02:08Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 176

davidjumani · 2021-03-19T05:02:26Z

@blueorangutan package

blueorangutan · 2021-03-19T05:03:02Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]

blueorangutan · 2021-03-19T05:24:48Z

Packaging result: ✔️ centos7 ✖️ centos8 ✔️ debian. SL-JID 177

DaanHoogland · 2021-03-19T08:57:35Z

utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java

        Assert.assertFalse(backoff.getWaiters().isEmpty());
        waitThread.interrupt();
-        Thread.sleep(100);
+        final int TIMEOUT_AFTER_INTERUPT = 500;


DaanHoogland

so what and why?

DaanHoogland · 2021-03-19T10:14:31Z

unit test only, merging

* 4.15: ui: Consider overprovisioning factor when displaying allocated progress bar (#4850) ui: Fix the styles action button (#4856) ui: Fill out the search filter form field after performing a filter (#4855) ui: fix add cluster form for vmware (#4841) ui: Fix add primary store during Zone Deployment for PreSetup protocol (#4845) tests: Extend wait time after interrupt (#4815)

Co-authored-by: dahn <daan.hoogland@gmail.com>

Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: dahn <daan.hoogland@gmail.com>

* 4.14: tests: Extend wait time after interrupt (#4815) (#4866)

Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: dahn <daan.hoogland@gmail.com>

shwstppr requested a review from DaanHoogland March 18, 2021 08:23

yadvr approved these changes Mar 18, 2021

View reviewed changes

DaanHoogland reviewed Mar 18, 2021

View reviewed changes

utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java Outdated Show resolved Hide resolved

davidjumani force-pushed the fix-backoff-test branch from d5f3e30 to b1fb8a9 Compare March 19, 2021 04:22

Update utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeB…

55dc6e4

…ackoffTest.java Co-authored-by: dahn <daan.hoogland@gmail.com>

davidjumani force-pushed the fix-backoff-test branch from b1fb8a9 to 55dc6e4 Compare March 19, 2021 04:35

DaanHoogland reviewed Mar 19, 2021

View reviewed changes

DaanHoogland approved these changes Mar 19, 2021

View reviewed changes

DaanHoogland merged commit 5895435 into apache:4.15 Mar 19, 2021

DaanHoogland deleted the fix-backoff-test branch March 19, 2021 10:14

davidjumani added a commit to shapeblue/cloudstack that referenced this pull request Mar 25, 2021

tests: Extend wait time after interrupt (apache#4815)

18fc4da

Co-authored-by: dahn <daan.hoogland@gmail.com>

davidjumani mentioned this pull request Mar 25, 2021

tests: Extend wait time after interrupt (#4815) #4866

Merged

DaanHoogland added a commit that referenced this pull request Mar 25, 2021

tests: Extend wait time after interrupt (#4815) (#4866)

0094cf4

Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: dahn <daan.hoogland@gmail.com>

DaanHoogland pushed a commit that referenced this pull request Mar 25, 2021

Merge release branch 4.14 to 4.15

918c3bd

* 4.14: tests: Extend wait time after interrupt (#4815) (#4866)

nlgordon pushed a commit to ippathways/cloudstack that referenced this pull request Aug 2, 2022

tests: Extend wait time after interrupt (apache#4815) (apache#4866)

8bc5cf5

Co-authored-by: dahn <daan.hoogland@gmail.com> Co-authored-by: dahn <daan.hoogland@gmail.com>

Conversation

davidjumani commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

davidjumani commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

davidjumani commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

davidjumani commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

davidjumani commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

davidjumani commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

davidjumani commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

davidjumani commented Mar 16, 2021

Uh oh!

blueorangutan commented Mar 16, 2021

Uh oh!

davidjumani commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

davidjumani commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

davidjumani commented Mar 17, 2021

Uh oh!

blueorangutan commented Mar 17, 2021

Uh oh!

Uh oh!

davidjumani commented Mar 19, 2021

Uh oh!

blueorangutan commented Mar 19, 2021

Uh oh!

blueorangutan commented Mar 19, 2021

Uh oh!

davidjumani commented Mar 19, 2021

Uh oh!

blueorangutan commented Mar 19, 2021

Uh oh!

blueorangutan commented Mar 19, 2021

davidjumani commented Mar 15, 2021 •

edited

Loading