Migrate VR codebase from Python2 to Python3 #4807

GabrielBrascher · 2021-03-12T17:11:56Z

Description

Considering the Python2 end of life we must migrate the VR's codebase to Python3.

This PR covers partially issue #3195. Additionally, this PR is a joint of the work done in #3730 and #4727.

Also: port cloud-grab-dependent-library-versions to python3

Conflicts were found & fixed: modified: systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py modified: systemvm/debian/root/health_checks/router_version_check.py modified: systemvm/test/runtests.sh

blueorangutan · 2021-03-12T17:42:38Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 100

blueorangutan · 2021-03-13T20:03:58Z

[S] Trillian test result (tid-124)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22007 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4807-t124-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 37 look OK, 49 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestAddVmToSubDomain>:setup	`Error`	56.85	test_accounts.py
test_DeleteDomain	`Error`	60.40	test_accounts.py
test_forceDeleteDomain	`Failure`	51.05	test_accounts.py
test_forceDeleteDomain	`Error`	68.48	test_accounts.py
test_01_user_remove_VM_running	`Error`	62.25	test_accounts.py
test_DeployVmAntiAffinityGroup_in_project	`Error`	64.51	test_affinity_groups_projects.py
test_DeployVmAffinityGroup	`Error`	46.06	test_affinity_groups.py
test_DeployVmAntiAffinityGroup	`Error`	4.24	test_affinity_groups.py
test_query_async_job_result	`Error`	42.50	test_async_job.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_3d_gpu_support	`Error`	71.13	test_deploy_vgpu_enabled_vm.py
test_05_deploy_vm_with_extraconfig_vmware	`Error`	57.31	test_deploy_vm_extra_config_data.py
test_list_vms_metrics	`Error`	43.22	test_metrics_api.py
test_deploy_vm_from_iso	`Error`	59.63	test_deploy_vm_iso.py
test_00_deploy_vm_root_resize	`Error`	60.50	test_deploy_vm_root_resize.py
test_01_native_to_native_network_migration	`Error`	45.54	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	54.51	test_migration.py
test_deployvm_firstfit	`Error`	41.17	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	`Error`	4.45	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing	`Error`	4.29	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata	`Error`	54.45	test_deploy_vm_with_userdata.py
test_deployvm_userdata_post	`Error`	4.37	test_deploy_vm_with_userdata.py
test_network_acl	`Error`	43.95	test_network_acl.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
test_delete_account	`Error`	51.66	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	93.58	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	44.02	test_network.py
test_reboot_router	`Error`	42.67	test_network.py
test_releaseIP	`Error`	43.52	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	86.07	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	44.92	test_network.py
test_03_destroySharedNetwork	`Failure`	1.07	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.15	test_network.py
test_01_nic	`Error`	43.78	test_nic.py
test_03_nic_multiple_vmware	`Error`	80.66	test_nic.py
test_03_deploy_vm_domain_service_offering	`Error`	41.91	test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering	`Error`	54.88	test_domain_vpc_offerings.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	54.48	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	46.31	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	46.34	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	50.44	test_internal_lb.py
test_01_deploy_kubernetes_cluster	`Failure`	49.51	test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster	`Failure`	44.13	test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	44.05	test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	52.23	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	`Failure`	48.09	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	47.13	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	48.10	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	48.06	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	253.01	test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_nic_secondaryip_add_remove	`Error`	50.61	test_multipleips_per_nic.py
test_nested_virtualization_vmware	`Error`	45.24	test_nested_virtualization.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	40.80	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	126.88	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.09	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.15	test_primary_storage.py
test_01_vpc_privategw_acl	`Failure`	42.28	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	48.37	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	40.27	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	44.36	test_privategw_acl.py
test_09_project_suspend	`Error`	54.32	test_projects.py
test_10_project_activation	`Error`	6.38	test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_01_so_removal_resource_update	`Error`	42.17	test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
test_02_routervm_iptables_policies	`Error`	43.08	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	40.90	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	41.19	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	42.16	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	88.63	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	91.42	test_routers_network_ops.py
test_03_RVR_Network_check_router_state	`Error`	90.76	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestScaleVm>:setup	`Error`	0.00	test_scale_vm.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	46.65	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestTemplates>:setup	`Error`	42.74	test_templates.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	45.61	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	90.03	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	133.43	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	177.88	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	289.36	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	333.86	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	383.37	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	41.93	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	2.18	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	3.20	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	3.19	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.16	test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume	`Error`	41.92	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	4.20	test_vm_life_cycle.py
test_03_migrate_detached_volume	`Error`	4.21	test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup	`Error`	67.80	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	113.25	test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots	`Error`	43.96	test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	111.86	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	48.44	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	42.30	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	43.35	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	54.60	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	43.33	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	53.51	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	46.37	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	49.17	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	51.16	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	41.83	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	39.95	test_vpc_vpn.py

fix py3 issue - python3: No module named pycodestyle

blueorangutan · 2021-03-15T15:31:04Z

[S] Trillian test result (tid-136)
Environment: kvm-ubuntu20 (x2), Advanced Networking with Mgmt server u20
Total time taken: 19827 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4807-t136-kvm-ubuntu20.zip
Intermittent failure detected: /marvin/tests/smoke/test_accounts.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_async_job.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_iso.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_with_userdata.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_domain_vpc_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_metrics_api.py
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_network_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_portforwardingrules.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_deployment_planner.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 39 look OK, 47 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestAddVmToSubDomain>:setup	`Error`	34.69	test_accounts.py
test_DeleteDomain	`Error`	29.82	test_accounts.py
test_forceDeleteDomain	`Failure`	29.82	test_accounts.py
test_forceDeleteDomain	`Error`	43.48	test_accounts.py
test_01_user_remove_VM_running	`Error`	36.11	test_accounts.py
test_DeployVmAntiAffinityGroup_in_project	`Error`	34.16	test_affinity_groups_projects.py
test_DeployVmAffinityGroup	`Error`	31.01	test_affinity_groups.py
test_DeployVmAntiAffinityGroup	`Error`	4.28	test_affinity_groups.py
test_query_async_job_result	`Error`	32.58	test_async_job.py
ContextSuite context=TestLoadBalance>:setup	`Error`	0.00	test_loadbalance.py
test_list_vms_metrics	`Error`	28.13	test_metrics_api.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_02_deploy_vm_with_extraconfig_kvm	`Error`	29.94	test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm	`Error`	4.32	test_deploy_vm_extra_config_data.py
test_deploy_vm_from_iso	`Error`	34.52	test_deploy_vm_iso.py
test_01_native_to_native_network_migration	`Error`	36.52	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	30.39	test_migration.py
test_00_deploy_vm_root_resize	`Error`	31.05	test_deploy_vm_root_resize.py
test_deployvm_firstfit	`Error`	28.99	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	`Error`	5.34	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdispersing	`Error`	4.30	test_deploy_vms_with_varied_deploymentplanners.py
test_network_acl	`Error`	31.14	test_network_acl.py
test_deployvm_userdata	`Error`	27.97	test_deploy_vm_with_userdata.py
test_deployvm_userdata_post	`Error`	4.32	test_deploy_vm_with_userdata.py
test_01_deploy_kubernetes_cluster	`Failure`	32.42	test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster	`Failure`	31.11	test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	30.08	test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	30.01	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	`Failure`	29.99	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	29.99	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	29.99	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	29.95	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	171.62	test_kubernetes_clusters.py
test_09_project_suspend	`Error`	28.05	test_projects.py
test_10_project_activation	`Error`	6.40	test_projects.py
ContextSuite context=TestRemoteDiagnostics>:setup	`Error`	0.00	test_diagnostics.py
test_delete_account	`Error`	46.67	test_network.py
ContextSuite context=TestPortForwarding>:setup	`Error`	76.74	test_network.py
ContextSuite context=TestPublicIP>:setup	`Error`	31.16	test_network.py
test_reboot_router	`Error`	31.48	test_network.py
test_releaseIP	`Error`	29.46	test_network.py
ContextSuite context=TestRouterRules>:setup	`Error`	60.03	test_network.py
test_01_deployVMInSharedNetwork	`Failure`	29.90	test_network.py
test_03_destroySharedNetwork	`Failure`	1.10	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.20	test_network.py
test_01_nic	`Error`	29.65	test_nic.py
test_03_deploy_vm_domain_service_offering	`Error`	29.73	test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering	`Error`	27.61	test_domain_vpc_offerings.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	`Error`	0.00	test_password_server.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	`Failure`	34.70	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	`Failure`	35.67	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	35.28	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Failure`	36.83	test_internal_lb.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_nic_secondaryip_add_remove	`Error`	44.67	test_multipleips_per_nic.py
test_01_create_delete_portforwarding_fornonvpc	`Error`	30.86	test_portforwardingrules.py
test_01_add_primary_storage_disabled_host	`Error`	98.88	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.24	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.38	test_primary_storage.py
test_01_vpc_privategw_acl	`Failure`	35.85	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	33.85	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	30.35	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Failure`	35.30	test_privategw_acl.py
ContextSuite context=TestResetVmOnReboot>:setup	`Error`	0.00	test_reset_vm_on_reboot.py
test_01_so_removal_resource_update	`Error`	30.05	test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup	`Error`	0.00	test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setup	`Error`	0.00	test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup	`Error`	0.00	test_router_dnsservice.py
test_02_routervm_iptables_policies	`Error`	30.00	test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies	`Error`	32.17	test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Error`	41.58	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Error`	43.29	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	62.06	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	61.45	test_routers_network_ops.py
test_03_RVR_Network_check_router_state	`Error`	62.26	test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setup	`Error`	0.00	test_routers.py
ContextSuite context=TestCpuCapServiceOfferings>:setup	`Error`	0.00	test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	30.63	test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
test_02_deploy_vm_from_direct_download_template	`Error`	31.16	test_templates.py
test_03_deploy_vm_wrong_checksum	`Error`	5.45	test_templates.py
ContextSuite context=TestTemplates>:setup	`Error`	56.05	test_templates.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	34.25	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	70.57	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	106.52	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	142.53	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	225.04	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	261.48	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	296.22	test_usage.py
test_01_deploy_vm_on_specific_host	`Error`	30.55	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	4.77	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	4.87	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	3.73	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	5.16	test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume	`Error`	31.15	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	6.40	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	62.62	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	126.21	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	81.03	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	82.00	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	34.66	test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup	`Error`	45.87	test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup	`Error`	0.00	test_volumes.py
ContextSuite context=TestVolumes>:setup	`Error`	0.00	test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Error`	0.52	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Error`	0.45	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Error`	31.37	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	33.47	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	34.70	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	`Error`	30.39	test_vpc_router_nics.py
test_02_VPC_default_routes	`Error`	32.54	test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn	`Failure`	33.31	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	32.08	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	`Failure`	29.91	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Failure`	30.13	test_vpc_vpn.py

rohityadavcloud · 2021-04-05T09:34:48Z

@blueorangutan package

blueorangutan · 2021-04-05T09:35:02Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-04-05T10:40:47Z

Packaging result: ✔️ centos7 ✔️ centos8 ✖️ debian. SL-JID 322

DaanHoogland · 2021-04-06T08:51:32Z

ATM this is a mix of python2 and python3 during the travis run and though I tried to implement it according to their spec, I had to put a question to them concerning a python not being found.
I'll add details and/or resolution later

rohityadavcloud · 2021-05-10T17:44:15Z

@GabrielBrascher are you working on this? cc @DaanHoogland

GabrielBrascher · 2021-05-10T21:02:00Z

@rhtyd I am doing some tests but it still need to cover more networks. I would appreciate any help testing it on environment with advanced networks + VPCs. I am testing at first with advacned networks + SG.

DaanHoogland · 2021-05-11T06:56:48Z

@GabrielBrascher , I'm on vacation since tomorrow ;) I will help you with testing this when I come back.

nvazquez · 2021-06-23T14:33:54Z

Hi @DaanHoogland @GabrielBrascher can you please resolve conflicts?

rohityadavcloud · 2021-09-08T05:12:41Z

Ping @GabrielBrascher any update on this should we target this for 4.17 instead?

rohityadavcloud · 2021-09-08T05:20:49Z

On second thought and after reviewing the changes, the risks to VR maybe huge so lets target this for 4.17.

GabrielBrascher · 2021-09-08T12:43:27Z

@rhtyd sorry for the delay here. We might need to postpone it to 4.17 indeed.

One of the biggest issues I am having is the testing, it can work great with my test environment (Advanced + SG, or basic network) but someone using a specific advanced network + VPC/VPN, etc could see issues.

I would appreciate it if anyone could check it on advanced without SG, I am mostly able to reproduce on a (decent) test environment with advanced + security groups.

GabrielBrascher · 2021-09-08T12:45:49Z

This is also one of the reasons I made this PR in an apache/clodustack branch. We can have any committer testing and contributing to it.

The main concerns are related to the fact that such implementation is quite complex (too many cases for testing and evaluating) and critical (a small python porting issue could mess with the VRs scripts).

nvazquez · 2022-02-05T17:20:10Z

Hi @GabrielBrascher should this be included on 4.17? Can you please fix the conflicts?

github-actions · 2022-04-07T05:56:32Z

Hi @${author}, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?

GabrielBrascher and others added 12 commits March 12, 2021 12:23

Make Virtual Router '.py' scripts Python3 compatible

ab01180

Fix pycodestyle 'errors'

1a9402d

Fix conflict with master

6b2330b

Also: port cloud-grab-dependent-library-versions to python3

Change Pylint to Pylint3

3a7a4f6

Fix indentation issues and use python3 when running pycodestyle checker

4604d47

Conflicts were found & fixed: modified: systemvm/debian/opt/cloud/bin/cs/CsNetfilter.py modified: systemvm/debian/root/health_checks/router_version_check.py modified: systemvm/test/runtests.sh

replace mock with unittest.mock

de248a6

pylint issues

e3c8b34

str f'ormat'

20288b2

read files in vr as list(byte[])

e7ba52a

write as byte[]

f151e7b

byte as separator on byte[]

a9043dc

ip to net address conversions

12b2a2f

GabrielBrascher added component:virtual-router Python Warning... Python code Ahead! python3 labels Mar 12, 2021

GabrielBrascher added this to the 4.16.0.0 milestone Mar 12, 2021

GabrielBrascher assigned DaanHoogland and GabrielBrascher Mar 12, 2021

pip3 install pycodestyle

eb2ae84

fix py3 issue - python3: No module named pycodestyle

rohityadavcloud closed this Apr 5, 2021

rohityadavcloud reopened this Apr 5, 2021

nvazquez mentioned this pull request Sep 7, 2021

Python 3 compatibility #3195

Closed

8 tasks

rohityadavcloud modified the milestones: 4.16.0.0, 4.17.0.0 Sep 8, 2021

DaanHoogland removed their assignment Oct 4, 2021

nvazquez modified the milestones: 4.17.0.0, 4.18.0.0 Mar 4, 2022

github-actions bot added the status:has-conflicts label Apr 7, 2022

nvazquez force-pushed the main branch from c56220f to 0f4c3af Compare June 6, 2022 15:14

GabrielBrascher closed this Aug 22, 2022

DaanHoogland removed this from the 4.18.0.0 milestone Oct 5, 2022

GabrielBrascher deleted the python3-vr branch October 30, 2024 14:09

Migrate VR codebase from Python2 to Python3 #4807

Migrate VR codebase from Python2 to Python3 #4807

Uh oh!

Conversation

GabrielBrascher commented Mar 12, 2021

Description

Uh oh!

blueorangutan commented Mar 12, 2021

Uh oh!

blueorangutan commented Mar 13, 2021

Uh oh!

blueorangutan commented Mar 15, 2021

Uh oh!

rohityadavcloud commented Apr 5, 2021

Uh oh!

blueorangutan commented Apr 5, 2021

Uh oh!

blueorangutan commented Apr 5, 2021

Uh oh!

DaanHoogland commented Apr 6, 2021

Uh oh!

rohityadavcloud commented May 10, 2021

Uh oh!

GabrielBrascher commented May 10, 2021

Uh oh!

DaanHoogland commented May 11, 2021

Uh oh!

nvazquez commented Jun 23, 2021

Uh oh!

rohityadavcloud commented Sep 8, 2021

Uh oh!

rohityadavcloud commented Sep 8, 2021

Uh oh!

GabrielBrascher commented Sep 8, 2021

Uh oh!

GabrielBrascher commented Sep 8, 2021

Uh oh!

nvazquez commented Feb 5, 2022

Uh oh!

github-actions bot commented Apr 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants