Skip to content

vr: fix python exception when configure VRs#4489

Merged
yadvr merged 1 commit intoapache:4.14from
ustcweizhou:4.14-fix-4474
Nov 23, 2020
Merged

vr: fix python exception when configure VRs#4489
yadvr merged 1 commit intoapache:4.14from
ustcweizhou:4.14-fix-4474

Conversation

@ustcweizhou
Copy link
Contributor

Description

This PR fixes #4474

before

root@r-27-VM:/var/cache/cloud# /opt/cloud/bin/configure.py monitor_service.json
ERROR:root:Command 'ip link show eth0 | grep 'state DOWN'' returned non-zero exit status 1

with this change

root@r-27-VM:/var/cache/cloud# /opt/cloud/bin/configure.py monitor_service.json
root@r-27-VM:/var/cache/cloud#

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

before
```
root@r-27-VM:/var/cache/cloud# /opt/cloud/bin/configure.py monitor_service.json
ERROR:root:Command 'ip link show eth0 | grep 'state DOWN'' returned non-zero exit status 1
```

with this change
```
root@r-27-VM:/var/cache/cloud# /opt/cloud/bin/configure.py monitor_service.json
root@r-27-VM:/var/cache/cloud#
```
@ravening
Copy link
Member

LGTM

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change makes sense, but not tested.

@yadvr yadvr added this to the 4.14.1.0 milestone Nov 20, 2020
@yadvr
Copy link
Member

yadvr commented Nov 20, 2020

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr yadvr added the type:bug label Nov 20, 2020
@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2418

@yadvr
Copy link
Member

yadvr commented Nov 20, 2020

@blueorangutan test

@blueorangutan
Copy link

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3228)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31812 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4489-t3228-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit 81ac9f9 into apache:4.14 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants