[Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates

[nvazquez]

Description

Fix for VMware SSVM recreation using deploy-as-is system VM templates

Fixes:

• Register a new system VM template
• Recreate SSVM -> ERROR

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

VMware environment

• Register a new system VM template
• Recreate SSVM

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2310

[nvazquez]

@blueorangutan test centos7 vmware67-u3

[blueorangutan]

@nvazquez unsupported parameters provided. Supported mgmt server os are: centos6, centos7, centos8, ubuntu. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[DaanHoogland]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[Pearl1594]

Verified fix. LGTM

[blueorangutan]

Trillian test result (tid-3109)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47441 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4437-t3109-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 83 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	Failure	785.40	test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store	Error	1.20	test_snapshots.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Error	19.50	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	Failure	355.58	test_vpc_redundant.py

[yadvr]

Approach LGTM, once the issue wrt other systemvm types is resolved we can test and merge. (I did n't manually test it)

[nvazquez]

@blueorangutan package

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2332

[nvazquez]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[yadvr]

@blueorangutan test centos7 vmware-67u3

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

[yadvr]

Let's merge once this passes, pl check if the last test env failed due to a regression @nvazquez thnx

[nvazquez]

@rhtyd tests running now, previous env failed to start the marvin VM

[blueorangutan]

Trillian test result (tid-3132)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38263 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4437-t3132-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	Failure	774.64	test_kubernetes_clusters.py