FIX issue in VR if remote access vpn is enabled

[ravening]

Description

Use both tcp protocol and module so that
vpn is enabled properly

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

[DaanHoogland]

@ravening can you give this a priority? as we are in code freeze, do we need this before 4.15?

[ravening]

@ravening can you give this a priority? as we are in code freeze, do we need this before 4.15?

@DaanHoogland yes its good to have this before 4.15 as its a bug fix

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2295

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3096)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33180 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4430-t3096-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

looks good but i am not sure why protocol would improve on the vpn instead of just restrict it. no regressions so i'm fine with it.

[yadvr]

LGTM - though I'm not sure adding the protocol tcp (instead of matcher tcp) makes any difference, I'm not sure what/how it fixes the issue; LGTM as no regression seen in tests

[weizhouapache]

this should be good.