Enhance UpdateDiskOfferingCmd

[GabrielBrascher]

This PR adds the ability to update the following disk offering fields

• cache-mode,
• IOPS (Read/Write) Rate, IOPS (Read/Write) Rate Max, IOPS (Read/Write) Rate Max Length
• Bytes (Read/Write) Rate, Bytes (Read/Write) Rate Max, Bytes (Read/Write) Rate Max Length

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

1. Execute multiple API requests updating different combinations with the included (13) parameters.
2. Assert that all parameters got updated on DB accordingly.
3. Ensure that IOPS/Bytes validations are properly done, e.g. expected Exceptions such as Bytes Write rate (5000) cannot be greater than Bytes Write maximum rate (3000).

[GabrielBrascher]

@blueorangutan package

[blueorangutan]

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[DaanHoogland]

@GabrielBrascher conflict arose, can you check?

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2194

[GabrielBrascher]

Fixed conflicts, going to re-run a few manual tests before moving back to ready to review.

@RodrigoDLopez can you please take a look at this PR? The conflicts were caused by a PR of yours; to fix the conflicts I did change slightly shouldUpdateDiskOffering adding cache mode. Nothing that would impact on tags updat process; however, I would appreciate some good eyes to check if all is good to go ;)

[RodrigoDLopez]

Hi @GabrielBrascher, nice enhancement
I did a quick review, code LGTM
i think this point that i mentioned is the only one that need to be fixed.

[GabrielBrascher]

@blueorangutan package

[blueorangutan]

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2199

[DaanHoogland]

code looks good

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[shwstppr]

LGTM on code changes

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2263

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3048)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37795 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4409-t3048-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Failure	314.38	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Failure	300.74	test_vpc_redundant.py