server: fix issue that vm guest os type is reset after updatetemplate

[ustcweizhou]

Description

Steps to reproduce the issue
(1) change vm guest os type
(2) update vm template (guest os type is not changed)
(3) vm guest os type is reset to guest os type of template.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[DaanHoogland]

lgtm

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2128

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2135

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2943)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31904 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4377-t2943-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster	Failure	0.01	test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster	Failure	0.01	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	Failure	0.01	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	Failure	0.01	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	Failure	0.01	test_kubernetes_clusters.py

[DaanHoogland]

@shwstppr i don't think these errors are relevant, can you comment? cc @rhtyd

[sureshanaparti]

moving before this line L#2096 template = _tmpltDao.createForUpdate(id); should be ok?

[shwstppr]

k8s smoke test failure is env related. It failed to get ISO in ready state cc @DaanHoogland

[shwstppr]

LGTM