hypervisor: Add Citrix Hypervisor 8x product name support

[shwstppr]

Description

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[yadvr]

LGTM, just branding support

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1779

[yadvr]

@blueorangutan test centos7 xenserver-71

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

[yadvr]

rekicked test manually

[yadvr]

@shwstppr was any testing done against Citrix Hypervisor 8.x, cc @DaanHoogland @andrijapanicsb

[andrijapanicsb]

none (afaik) @rhtyd - as the product name is changed, so is writen like that in DB, and code doesn't recognise that HV (this PR - I never tested)

[blueorangutan]

Trillian test result (tid-2503)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50543 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4271-t2503-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	Error	185.62	test_kubernetes_supported_versions.py
test_01_scale_vm	Failure	24.56	test_scale_vm.py

[harikrishna-patnala]

As far as I remember we also have to address the name change of XenServer Tools to Citrix Hypervisor Tools. This must be during attach and dettach ISO operations.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[shwstppr]

https://github.com/apache/cloudstack/blob/master/plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java#L121-L122
@harikrishna-patnala this is the only remaining place where I see Xenserver Tools name used in java code. Does this need updating?

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1821

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1825

[yadvr]

@andrijapanicsb @borisstoyanov - are you LGTM on it, have we tested it (assuming XS/Citrix Hypervisor 8.0 iso was available)? Or we can merge based on regression testing?

[andrijapanicsb]

I haven't tested this, we don't have the Trillian template for this, so it would requre manually building a small CS 8.1 pool and verifying there...takes time.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-2011

[DaanHoogland]

code looks good but I have no idea of completeness. extensive xen 8 testing is needed for this.

[shwstppr]

@blueorangutan help

[blueorangutan]

@shwstppr I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [additional tests]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Additional tests: list of space separated tests with paths relative to the test/integration directory, for example: component/test_acl_listvm.py component/test_volumes.py
Note: when additional tests are passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2092

[shwstppr]

@blueorangutan test centos7 xcpng81

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + xcpng81) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2876)
Environment: xcpng81 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34667 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4271-t2876-xcpng81.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_scale_vm	Failure	4.30	test_scale_vm.py

[shwstppr]

Screenshots from local testing for reference cc @rhtyd @harikrishna-patnala @davidjumani @DaanHoogland @Pearl1594 @weizhouapache @ravening
Will be great if others can test/review

Citrix Hypervisor 8.1 host added

System VMs running

VM deployment working

VR seems okay as well

[yadvr]

Thanks for test results @shwstppr, merging this based on regression tests and code LGTM from Daan and I.