Skip network migration tests for not supported hypervisors instead of failing by nvazquez · Pull Request #3021 · apache/cloudstack

nvazquez · 2018-11-10T21:04:53Z

Description

Avoid exception when hypervisor not supported:

2018-11-10 11:04:17,858 - CRITICAL - EXCEPTION:
...in setUpClass\n    raise unittest.SkipT est("This feature is supported "\n', 'SkipTest: This feature is supported only on Vmware and KVM\n']

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

… failing

nvazquez · 2018-11-11T00:04:35Z

@blueorangutan package

blueorangutan · 2018-11-11T00:05:12Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

nvazquez · 2018-11-11T02:02:30Z

@blueorangutan package

blueorangutan · 2018-11-11T02:03:12Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-11T12:43:48Z

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2418

nvazquez · 2018-11-11T16:19:07Z

@blueorangutan package

blueorangutan · 2018-11-11T16:19:15Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-11T16:50:48Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2419

nvazquez · 2018-11-11T16:52:56Z

@blueorangutan test matrix

blueorangutan · 2018-11-11T16:53:15Z

@nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2018-11-11T23:29:59Z

Trillian test result (tid-3159)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22052 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3021-t3159-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 65 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_native_to_native_network_migration	`Error`	0.00	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	0.00	test_migration.py
test_01_scale_vm	`Error`	13.44	test_scale_vm.py

blueorangutan · 2018-11-11T23:45:18Z

Trillian test result (tid-3160)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 22865 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3021-t3160-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr · 2018-11-12T06:13:27Z

Still failed for xenserver, can you check @nvazquez ?

borisstoyanov

perhaps these migration are not allowed on Xen? could be limitation of the hypervisor or licensing issue?

yadvr · 2018-11-13T01:09:28Z

@blueorangutan test centos7 xenserver-65sp1

blueorangutan · 2018-11-13T01:10:21Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

DaanHoogland · 2018-11-13T06:46:27Z

test/integration/smoke/test_migration.py

-        # Enable Network offering
-        cls.network_offering_all.update(cls.api_client, state='Enabled')
+        cls._cleanup = []
+        if not cls.hypervisorNotSupported:


a double negation. can we reverse the meaning (and name) of the variable?

I would agree but would need to check if the annotation @skipTestIf accepts negations

blueorangutan · 2018-11-13T22:35:50Z

Trillian test result (tid-3173)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45581 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3021-t3173-xenserver-65sp1.zip
Intermittent failure detected: /marvin/tests/smoke/test_migration.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_native_to_native_network_migration	`Error`	0.00	test_migration.py
test_02_native_to_native_vpc_migration	`Error`	0.00	test_migration.py

nvazquez · 2018-11-14T02:43:59Z

Failures fixed, tested in my local environment

:~/cloudstack$ cat /tmp//MarvinLogs/test_migration_YWC2XZ/results.txt 
Verify Migration for an isolated network nativeOnly ... SKIP: Skipping test: Reason -  hypervisorNotSupported
Verify Migration for a vpc network nativeOnly ... SKIP: Skipping test: Reason -  hypervisorNotSupported

----------------------------------------------------------------------
Ran 2 tests in 0.028s

OK (SKIP=2)

@blueorangutan package

blueorangutan · 2018-11-14T02:44:27Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-11-14T03:05:11Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2439

nvazquez · 2018-11-14T03:07:44Z

@blueorangutan test centos7 xenserver-65sp1

blueorangutan · 2018-11-14T03:08:27Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) has been kicked to run smoke tests

blueorangutan · 2018-11-14T09:25:16Z

Trillian test result (tid-3179)
Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 21152 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3021-t3179-xenserver-65sp1.zip
Smoke tests completed. 68 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Ajustes em fluxos de agendamentos de _backups_ Closes #2935, #3021, #3024, and #3037 See merge request scclouds/scclouds!1294

Skip network migration tests for not supported hypervisors instead of…

588d236

… failing

nvazquez requested review from PaulAngus and yadvr November 10, 2018 21:05

rafaelweingartner approved these changes Nov 11, 2018

View reviewed changes

yadvr added this to the 4.11.2.0 milestone Nov 12, 2018

yadvr modified the milestones: 4.11.2.0, 4.11.3.0 Nov 12, 2018

borisstoyanov reviewed Nov 12, 2018

View reviewed changes

DaanHoogland reviewed Nov 13, 2018

View reviewed changes

Fix failure while skipping tests due to unset variables

012895d

yadvr approved these changes Nov 14, 2018

View reviewed changes

yadvr added the status:testing label Nov 14, 2018

yadvr merged commit 4fabbdb into apache:4.11 Nov 14, 2018

nvazquez deleted the fixtestcaseerror branch April 6, 2020 14:43

winterhazel pushed a commit that referenced this pull request Jan 28, 2026

Merge branch 'backup-schedules-general-fixes' into '4.20.0.0-scclouds'

1978c18

Ajustes em fluxos de agendamentos de _backups_ Closes #2935, #3021, #3024, and #3037 See merge request scclouds/scclouds!1294

Conversation

nvazquez commented Nov 10, 2018

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

nvazquez commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

nvazquez commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

nvazquez commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

blueorangutan commented Nov 11, 2018

Uh oh!

yadvr commented Nov 12, 2018

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Nov 13, 2018

Uh oh!

blueorangutan commented Nov 13, 2018

Uh oh!

DaanHoogland Nov 13, 2018

Choose a reason for hiding this comment

Uh oh!

nvazquez Nov 13, 2018

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Nov 13, 2018

Uh oh!

nvazquez commented Nov 14, 2018

Uh oh!

blueorangutan commented Nov 14, 2018

Uh oh!

blueorangutan commented Nov 14, 2018

Uh oh!

nvazquez commented Nov 14, 2018

Uh oh!

blueorangutan commented Nov 14, 2018

Uh oh!

blueorangutan commented Nov 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants