Discover tags field on superclass of API responses#3005
Conversation
| response.setRelated(responseName); | ||
|
|
||
| Field[] responseFields = apiCmdAnnotation.responseObject().getDeclaredFields(); | ||
| List<Field> responseFields = new ArrayList<>(Arrays.asList(responseClass.getDeclaredFields())); |
There was a problem hiding this comment.
Instead of doing this whole loop thing, what about using org.reflections.ReflectionUtils.getAllFields(Class<?>)? It will produce the same result with much less code.
d15243e to
70a3075
Compare
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2470 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-3232)
|
borisstoyanov
left a comment
There was a problem hiding this comment.
LGMT, based on test results
|
Lgtm, merged. |
Description
Updated
ApiServiceDiscoveryImplto check superclasses of API responses for fields.Fixes: #3002
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Additional unit test and tested locally to verify the tags field was present in the output of listApis response for listVirtualMachines API.