CLOUDSTACK-9595: Fix regression introduced in #1762

[yadvr]

The assignDedicateIpAddress previously had marked the newly fetched
IP as allocated but now it does not do that. This fails for VPCs
where SNATs IP are retained as allocating and not allocated after
creation.

@yvsubhash @rafaelweingartner and please review.
@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[rafaelweingartner]

Thanks @rhtyd

[rafaelweingartner]

You can return directly the call to fetchNewPublicIp.

I have not checked. What is that boolean flag you changed there?

[yadvr]

@rafaelweingartner actually there is a ip variable that is used in finally which is why I assign and then return see the code below this line.

[rafaelweingartner]

ok, now I saw it.
Thanks

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1436

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yvsubhash]

@rhtyd Code changes are fine LGTM for code

[yadvr]

Thanks for confirming @yvsubhash, I'll merge the fix once test results arrive.

[blueorangutan]

Trillian test result (tid-1839)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28609 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2370-t1839-kvm-centos7.zip
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpc_privategw_acl	Failure	41.24	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Failure	137.19	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	116.94	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	222.45	test_privategw_acl.py
test_02_create_template_with_checksum_sha1	Error	5.16	test_templates.py
test_03_create_template_with_checksum_sha256	Error	5.15	test_templates.py
test_04_create_template_with_checksum_md5	Error	5.15	test_templates.py
test_01_volume_usage	Failure	856.60	test_usage.py
test_01_vpc_remote_access_vpn	Failure	65.69	test_vpc_vpn.py

[yadvr]

Tests LGTM, the new vpc vpn failure is due to create vpn user failing. I'll merge this based on tests and two code reviews.