CLOUDSTACK-9887 ignore bogus default gateway#2055
Merged
karuturi merged 2 commits intoapache:4.9from May 17, 2017
Merged
Conversation
when a shared network is secondary the default gateway gets overwritten by a bogus one dnsmasq does the right thing and replaces it with its own default which is not good for us so check for '0.0.0.0'
Member
|
@DaanHoogland can you fix the commit message to include the JIRA id |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-662 |
Contributor
Author
|
@rhtyd the PR has the ticket id so the merge commit will as well. Is that not enough? |
Member
|
LGTM. |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1021)
|
Member
|
@karuturi can this be merged? |
Member
|
LGTM, based on logic and code but could not test |
Member
|
LGTM |
Contributor
|
I think it is fixed by #1766 for CLOUDSTACK-9598 |
Contributor
Author
|
@ustcweizhou #1766 doesn't fix the issue completely as it still remains in 4.9 |
Contributor
|
@DaanHoogland are you testing on 4.9.2 or 4.9 branch ? This issue is related to commit c81b338 |
Contributor
Author
|
@ustcweizhou I am looking into this for a customer running 4.9.1 |
Contributor
|
@DaanHoogland However, I do not think this PR fixes the issue. If the gateway ip is not set in dhcp-option, other vms in this network will not get the gateway, even the ip is on the default nic. |
Contributor
|
@DaanHoogland |
Contributor
Author
|
@ustcweizhou It is worth a try. Can you confirm that no config line 3 is present for the tagged interface? |
Contributor
Author
|
@ustcweizhou do you have a link to that patch, you refer to? |
Contributor
|
@DaanHoogland The gateway is set after the change, so the dhcp-option you mentioned is configured with correct gateway. here you are |
Contributor
Author
|
@ustcweizhou thanks for the patch, i'll look into the replace code. if the gateway line is removed completely this is good. I'll test your patch as well. |
Contributor
Author
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-716 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Member
|
LGTM |
|
Trillian test result (tid-1085)
|
Member
|
LGTM, based on test results and review. |
yadvr
approved these changes
May 16, 2017
Member
|
@ustcweizhou @DaanHoogland you're both LGTM on this as well I suppose? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when a shared network is secondary the default gateway gets overwritten by a bogus one
dnsmasq does the right thing and replaces it with its own default which is not good for us
so check for '0.0.0.0'