Skip to content

CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone#1991

Merged
asfgit merged 1 commit intomasterfrom
unknown repository
Mar 8, 2017
Merged

CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone#1991
asfgit merged 1 commit intomasterfrom
unknown repository

Conversation

@jayapalu
Copy link
Contributor

@jayapalu jayapalu commented Mar 6, 2017

Fixed issue in deploying vm in basic zone.
There is issue in ipset command with xenserver 6.5. In util.pread2 ipset and -N is passed as single string and it caused the issue in command failure.

util.pread2(['/bin/bash', '-c', 'ipset', '-N ', tmpname , type])

tmpname = 'ipsetqzvxtmp'
try:
util.pread2(['/bin/bash', '-c', 'ipset -N ' + tmpname + type])
util.pread2(['/bin/bash', '-c', 'ipset', '-N ', tmpname , type])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the space after "-N". "-F" . "-X" needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the patch

@ustcweizhou
Copy link
Contributor

code LGTM. not tested.

@jayapalu
Copy link
Contributor Author

jayapalu commented Mar 6, 2017

I am testing it again. Please wait till I update

@jayapalu
Copy link
Contributor Author

jayapalu commented Mar 6, 2017

Updated the patch. Tested it no issues found.
Please review this PR.
Also look at the CLOUDSTACK-9821 comments.

@karuturi
Copy link
Member

karuturi commented Mar 7, 2017

@borisstoyanov can you start the tests on this?

@borisstoyanov
Copy link
Contributor

basic zone is not supported currently with BO @karuturi

@karuturi
Copy link
Member

karuturi commented Mar 8, 2017

I manually verified this. merging this now.

@asfgit asfgit merged commit 43a991d into apache:master Mar 8, 2017
asfgit pushed a commit that referenced this pull request Mar 8, 2017
CLOUDSTACK-9821: Fixed issue in deploying vm in basic zoneFixed issue in deploying vm in basic zone.
There is issue in ipset command with xenserver 6.5. In util.pread2 ipset and -N is passed as single string and it caused the issue in command failure.

 util.pread2(['/bin/bash', '-c', 'ipset', '-N ',  tmpname , type])

* pr/1991:
  CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone

Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>
@cloudmonger
Copy link

ACS CI BVT Run

Sumarry:
Build Number 441
Hypervisor xenserver
NetworkType Advanced
Passed=101
Failed=4
Skipped=7

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

  • test_non_contigiousvlan.py

  • test_extendPhysicalNetworkVlan Failed

  • test_volumes.py

  • test_06_download_detached_volume Failed

  • test_routers_network_ops.py

  • test_01_isolate_network_FW_PF_default_routes_egress_true Failed

  • test_03_RVR_Network_check_router_state Failing since 2 runs

Skipped tests:
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants