CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency#1670
Merged
asfgit merged 1 commit intoapache:4.9from Sep 1, 2016
Merged
CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency#1670asfgit merged 1 commit intoapache:4.9from
asfgit merged 1 commit intoapache:4.9from
Conversation
| ALTER TABLE cloud.nic_ip_alias ENGINE=INNODB; | ||
| ALTER TABLE cloud.sslcerts ENGINE=INNODB; | ||
| ALTER TABLE cloud.op_lock ENGINE=INNODB; | ||
| ALTER TABLE cloud.op_nwgrp_work ENGINE=INNODB; |
Contributor
There was a problem hiding this comment.
For op_lock and op_nwgrp_work tables engine is MEMORY, not sure of the reason. Was there any perf. issues addressed? These exists since the start.
Member
There was a problem hiding this comment.
Yes, they have existed since 4.0. I checked git history, I think there is nothing specific to this table, they can be migrated to InnoDB. I'm running a local 4.9.0 CloudStack environment with these changes and it is working alright.
Member
|
LGTM, tested with a local installation, running it for past 3 days. |
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Contributor
|
LGTM, based on review. |
Member
|
Thanks @borisstoyanov |
asfgit
pushed a commit
that referenced
this pull request
Sep 1, 2016
CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency * pr/1670: CLOUDSTACK-9481: Convert MyISAM table to InnoDB for consistency Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
lucas-a-martins
pushed a commit
to scclouds/cloudstack
that referenced
this pull request
Jan 29, 2024
…r-level' into '4.18.0.0-scclouds' Atualizar configuração `vpc.max.networks` e colocá-la à nível de _cluster_ Closes apache#1670 See merge request scclouds/scclouds!699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.