CLOUDSTACK-9352: Test fails in Widows as the file separator "/" is different from "\" #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBrascher
changed the title
Contributor
|
reviewed your code change and looks good. Please post the test result. |
GabrielBrascher
force-pushed
the
lrg-cs-hackday-038
branch
from
a835140 to
bb6bb34
Compare
Contributor
|
I need one more LGTM and if you can post some proof this is working as expected, I will feel better about merging it. Thanks... :) |
GabrielBrascher
force-pushed
the
lrg-cs-hackday-038
branch
from
bb6bb34 to
250d810
Compare
Member
Author
|
@swill it succesfully builds in windows: build-result.txt; Not sure if it helps, but there is also a print showing the test failing. After the adjustment the test is ok: Let me know if you need more information :) |
Contributor
|
That is what I was looking for. Thank you sir... :) |
File separator in windows is different from linux (the expected in the test); thus, the test *com.cloud.utils.SwiftUtilTest.testSplitSwiftPath()* will fail in windows. The problem is that the input of the test is *"container/object"* but the tested method uses the *File.separator* (that depends from the OS), in the windows the tested method (*com.cloud.utils.SwiftUtil.splitSwiftPath(String)*) looks for a "\" in windows systems, resulting in an empty string and consequently a failure in the test. Some solutions: - the simple way is to create a string `String input = "container" + File.separator + "object";`, thus independent of the OS, the test will succeed. - a tricky solution is to mock the final static variable *File.separator* and return "/". I picked the easy way.
GabrielBrascher
force-pushed
the
lrg-cs-hackday-038
branch
from
250d810 to
4be5c2e
Compare
asfgit
pushed a commit
that referenced
this pull request
Apr 25, 2016
CLOUDSTACK-9352: Test fails in Widows as the file separator "/" is different from "\"**Problem:**
File separator in windows ("\") is different from the expected in the test ("/"); thus, the test *com.cloud.utils.SwiftUtilTest.testSplitSwiftPath()* will fail in Windows systems.
The problem is that the input of the test is "*container/object*" but the tested method uses the *File.separator* (that depends from the OS), in windows systems the tested method (*com.cloud.utils.SwiftUtil.splitSwiftPath(String)*) looks for a "\", as the string does not contain "\" it returns an empty string and consequently results in a test failure.
**Solution:**
Create a string `String input = "container" + File.separator + "object";`, with that the test will validate the tested method verifying if the method splits the string around matches of the given regular expression (in this case *File.separator*).
*JIRA link: https://issues.apache.org/jira/browse/CLOUDSTACK-9352*
* pr/1498:
Test fails in Widows as the file separator "/" is different from "\"
Signed-off-by: Will Stevens <williamstevens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
File separator in windows ("") is different from the expected in the test ("/"); thus, the test com.cloud.utils.SwiftUtilTest.testSplitSwiftPath() will fail in Windows systems.
The problem is that the input of the test is "container/object" but the tested method uses the File.separator (that depends from the OS), in windows systems the tested method (com.cloud.utils.SwiftUtil.splitSwiftPath(String)) looks for a "", as the string does not contain "" it returns an empty string and consequently results in a test failure.
Solution:
Create a string
String input = "container" + File.separator + "object";, with that the test will validate the tested method verifying if the method splits the string around matches of the given regular expression (in this case File.separator).JIRA link: https://issues.apache.org/jira/browse/CLOUDSTACK-9352