Refactor test_vpc_vpn, add test for multiple VPNs

[bheuvel]

Refactored to clear usage of setup/setupClass, teardown/teardownClass

Refactored TestVpcSite2SiteVpn to include class TestRVPCSite2SiteVpn as a test, thereby removing redundant code.

Added test for setting up multiple (3) Site2Site VPNs (from/on one VPC)

[bvbharatk]

ACS CI BVT Run

Sumarry:
Build Number 60
Hypervisor xenserver
NetworkType Advanced
Passed=67
Failed=5
Skipped=3

Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

• test_vpc_vpn.py
  • ContextSuite context=TestVpcRemoteAccessVpn>:setup Failed
  • ContextSuite context=TestVpcSite2SiteVpn>:setup Failed
• test_deploy_vm_iso.py
  • test_deploy_vm_from_iso Failing since 3 runs
• test_volumes.py
  • test_06_download_detached_volume Failing since 3 runs
• test_vm_life_cycle.py
  • test_10_attachAndDetach_iso Failed

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

[yadvr]

@bheuvel rebase against latest master, change base branch please. This may not be applicable anymore.

[yadvr]

@bheuvel is this still relevant as there have been several change in code, can you rebase and update on the changes/status?

[yadvr]

Given no engagement/discussion from the author and that the smoke/test_vpc_vpn.py changes from this PR are not entirely applicable, however the test needs to be refactored in master branch. It was quite recently fixed in #2211 with an additional test case from @swill 's s2s multiple option fix/testcase. Closing this PR on this remark, please reopen after rebasing fixing against latest mater, or submit a new change per the latest master as next step. Thanks.