Migrate volume improvements, to bypass secondary storage when copy volume between pools is allowed directly

[sureshanaparti]

Description

This PR improves migrate volume, to bypass secondary storage when copy volume between pools is allowed directly.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested migrate volumes between different NFS pools in the cluster, and between Local Storage to NFS and vice versa.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

❌ Patch coverage is 13.25301% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.39%. Comparing base (70a4503) to head (d646d67).

Files with missing lines	Patch %	Lines
...tack/storage/motion/AncientDataMotionStrategy.java	2.94%	33 Missing ⚠️
...stack/engine/orchestration/VolumeOrchestrator.java	33.33%	4 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	4 Missing ⚠️
...ack/engine/subsystem/api/storage/ClusterScope.java	0.00%	3 Missing ⚠️
...dstack/engine/subsystem/api/storage/HostScope.java	40.00%	3 Missing ⚠️
...dstack/engine/subsystem/api/storage/ZoneScope.java	0.00%	3 Missing ⚠️
...oudstack/storage/volume/VolumeDataFactoryImpl.java	0.00%	3 Missing ⚠️
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	0.00%	3 Missing ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	0.00%	2 Missing ⚠️
...a/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java	0.00%	2 Missing ⚠️
... and 11 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11625      +/-   ##
============================================
- Coverage     17.39%   17.39%   -0.01%     
+ Complexity    15285    15281       -4     
============================================
  Files          5888     5888              
  Lines        526130   526198      +68     
  Branches      64232    64248      +16     
============================================
- Hits          91542    91534       -8     
- Misses       424255   424330      +75     
- Partials      10333    10334       +1     

Flag	Coverage Δ
uitests	3.62% <ø> (ø)
unittests	18.44% <13.25%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14980

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[Copilot]

Pull Request Overview

This PR enhances the volume migration functionality to bypass secondary storage when direct copy between pools is possible, improving performance for supported pool types.

Key changes:

• Added poolType parameter to volume import/update operations to track storage pool types
• Implemented logic to determine when secondary storage can be bypassed during volume migration
• Updated volume database records to include pool type information when pools change

Reviewed Changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
AncientDataMotionStrategy.java	Adds bypass logic for supported pool types (NFS, Filesystem) with scope validation
VolumeOrchestrator.java	Updates import/update methods to include poolType parameter
Multiple volume management files	Adds setPoolType() calls when updating volume pool assignments
KVMStorageProcessor.java	Fixes path handling logic for volume copying between pools
VMSnapshotManagerImpl.java	Corrects spelling error in exception messages
Scope classes	Adds toString() methods for better debugging

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14981

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-14312)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53901 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11625-t14312-kvm-ol8.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_scale_kubernetes_cluster	Failure	1.16	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	Failure	28.84	test_kubernetes_clusters.py