ui: fix tab name in query params #11590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When name of a tab is defined as function then query params are wrongly set on selection of the tab. This PR fixes the behaviour by always checking the type of name defined. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11590 +/- ##
============================================
- Coverage 16.17% 16.17% -0.01%
Complexity 13286 13286
============================================
Files 5656 5656
Lines 498015 498015
Branches 60406 60406
============================================
- Hits 80538 80536 -2
- Misses 408515 408517 +2
Partials 8962 8962
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
clgtm
verified in qa:
…/simulator/#/guestnetwork/80e5ad76-be5d-4a8a-b74b-a3187cc71a05?tab=function(e)%7Breturn%22Shared%22%3D%3D%3De.type%3F%22ip.addresses%22%3A%22public.ip.addresses%22%7D
4.20, vs
.../simulator/pr/11590/#/guestnetwork/80e5ad76-be5d-4a8a-b74b-a3187cc71a05?tab=ip.addresses
in the pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When name of a tab is defined as function then query params are wrongly set on selection of the tab. This PR fixes the behaviour by always checking the type of name defined.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Check URL in browser address bar,
How Has This Been Tested?
How did you try to break this feature and the system with this change?