Ovmsupport 3.2.1/3.3.x rebased and condensed in one single commit.#113
Ovmsupport 3.2.1/3.3.x rebased and condensed in one single commit.#113snuf wants to merge 1 commit intoapache:masterfrom
Conversation
|
Hey @snuf thanks for that! It makes it easier to everyone to review and merge your stuff. First thing tomorrow morning! |
|
@snuf after a quick look at the diff I feel so emotional with the code I'm seeing, neat stuff :) 😲 |
|
@bhaisaab thanks man!, it's bound to have some bugs and nasty bits here and there. Already have NSX/NVP integration on the map for the next iteration though :) |
|
Seems to have caused the RAT check to fail. I do see the license headers in the new files, so I guess the format is not an exact match? (https://builds.apache.org/job/cloudstack-rat-master/6275/artifact/target/rat.txt) |
|
@likitha Hmm the format is indeed different, though the content is the same, mine is the one that comes with eclipse and has a full line of * at the top and bottom and is missing some spaces. Should I change it or should RAT accept it as it is a valid license ? |
Adds dedicated section for zone/pod/cluster/host to dedicate that resource to a domain (and account). Implements the list, dedicate and release APIs. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> Co-authored-by: Rohit Yadav <rohit@apache.org>
@bhaisaab
Rebasing the other stuff was a pain (4400 commits behind is no pleasure). Decided to do a "re-implement" against master after two rebase attempts, and this is the result.
This replaces #99
Cheers,
Funs