Skip to content

Ovmsupport 3.2.1/3.3.x rebased and condensed in one single commit.#113

Closed
snuf wants to merge 1 commit intoapache:masterfrom
snuf:ovm3rebase
Closed

Ovmsupport 3.2.1/3.3.x rebased and condensed in one single commit.#113
snuf wants to merge 1 commit intoapache:masterfrom
snuf:ovm3rebase

Conversation

@snuf
Copy link

@snuf snuf commented Mar 11, 2015

@bhaisaab

Rebasing the other stuff was a pain (4400 commits behind is no pleasure). Decided to do a "re-implement" against master after two rebase attempts, and this is the result.

This replaces #99

Cheers,

Funs

@snuf snuf mentioned this pull request Mar 11, 2015
@yadvr
Copy link
Member

yadvr commented Mar 11, 2015

Hey @snuf thanks for that! It makes it easier to everyone to review and merge your stuff. First thing tomorrow morning!

@yadvr
Copy link
Member

yadvr commented Mar 11, 2015

@snuf after a quick look at the diff I feel so emotional with the code I'm seeing, neat stuff :) 😲

@snuf
Copy link
Author

snuf commented Mar 11, 2015

@bhaisaab thanks man!, it's bound to have some bugs and nasty bits here and there. Already have NSX/NVP integration on the map for the next iteration though :)
I'll update the wiki tomorrow with the correct information and how the hypervisor is supposed to be configured.

@sebgoa
Copy link
Member

sebgoa commented Mar 11, 2015

That's ok @bhaisaab you will be fine, @snuf is the huggy type you two can get emotional about that code at the next cloudstack day.

@yadvr
Copy link
Member

yadvr commented Mar 12, 2015

@Runseb true that :)

@snuf we're good as long as the bugs are in the plugin itself and don't affect the core. Looking at the code, does not look like the several core changes at all.

Built with noredist, able to deploy a KVM zone without any issues (just to check any side effects). Merging now.

@asfgit asfgit closed this in c27c694 Mar 12, 2015
@likitha
Copy link

likitha commented Mar 12, 2015

Seems to have caused the RAT check to fail. I do see the license headers in the new files, so I guess the format is not an exact match? (https://builds.apache.org/job/cloudstack-rat-master/6275/artifact/target/rat.txt)

@snuf
Copy link
Author

snuf commented Mar 12, 2015

@likitha Hmm the format is indeed different, though the content is the same, mine is the one that comes with eclipse and has a full line of * at the top and bottom and is missing some spaces. Should I change it or should RAT accept it as it is a valid license ?

@yadvr
Copy link
Member

yadvr commented Mar 12, 2015

@snuf @likitha yeah, RAT expects a certain format. Just fixed.

@snuf
Copy link
Author

snuf commented Mar 12, 2015

@bhaisaab @likitha cool thanks!

yadvr added a commit that referenced this pull request Jan 20, 2021
Adds dedicated section for zone/pod/cluster/host to dedicate that resource to a domain (and account). Implements the list, dedicate and release APIs.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Rohit Yadav <rohit@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants