Changes baseurl for downloading kubectl#11040
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11040 +/- ##
=========================================
Coverage 16.60% 16.60%
Complexity 13925 13925
=========================================
Files 5730 5730
Lines 508254 508254
Branches 61789 61789
=========================================
+ Hits 84387 84388 +1
Misses 414431 414431
+ Partials 9436 9435 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
hey @daviftorres , thanks for the contribution. As far as I can see there is no automation to be tested as it is just instructions in the UI. Do you agree? |
|
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - Thanks @daviftorres!
|
UI build: ✔️ |
Correct! |
|
Awesome work, congrats on your first merged pull request! |
Description
This PR changes the
baseurlthat composes the link to downloadkubectlon the Access tab of Kubernetes clusters as reported in #11036.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested with
wgetand the URL.How did you try to break this feature and the system with this change?