Reset the pool id when create volume fails on the allocated pool, and update the resize error when no endpoint exists

[sureshanaparti]

Description

This PR resets the pool id when create volume fails on the allocated pool. Also, adds check for endpoint to avoid NPE, while resizing volume and updates the resize error when no endpoint exists.

Noticed an issue during DATA volume re-attach, the pool id is not reverted after first create volume failure during attach operation, thereafter CloudStack couldn't find any suitable pools for volume creation even there are pools available with enough capacity.

The pool id is persisted while creating the volume here:

cloudstack/engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/PrimaryDataStoreImpl.java

Lines 333 to 339 in 55c8138

	} else if (obj.getType() == DataObjectType.VOLUME) {
	VolumeVO vol = volumeDao.findById(obj.getId());
	if (vol != null) {
	vol.setPoolId(getId());
	volumeDao.update(vol.getId(), vol);
	}
	}

, the updated pool id id not reverted when volume creation fails. On next create volume attempt, CloudStack couldn't find any suitable pools as the pool is already assigned to volume which is in Allocated state (and storage pool compatibility check fails). Ensure volume is not assigned to any pool if create volume fails (so the next creation job would pick the suitable pool).

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Re-attached volume after first attach failed.

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (55c8138) to head (8d2b008).
Report is 5 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...e/cloudstack/storage/volume/VolumeServiceImpl.java	0.00%	11 Missing ⚠️
...e/driver/CloudStackPrimaryDataStoreDriverImpl.java	0.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10777   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11332    11337    +5     
=========================================
  Files          5412     5412           
  Lines        475033   475052   +19     
  Branches      57963    57966    +3     
=========================================
+ Hits          72048    72060   +12     
- Misses       394930   394935    +5     
- Partials       8055     8057    +2     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.89% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13174

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-13149)

[weizhouapache]

code lgtm

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13171)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49228 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10777-t13171-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13210

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13224

[rohityadavcloud]

LGTM didn't test

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13194)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48672 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10777-t13194-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File