[router] make a distinction between fatal errors, warnings and unknown as healthcheck result

[DaanHoogland]

Description

This PR...

Fixes: #9800

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

added some fake tests to test the UI:

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 23.73737% with 151 lines in your changes missing coverage. Please review.

Project coverage is 16.13%. Comparing base (01d87b7) to head (f870fad).
Report is 2 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...ork/router/VirtualNetworkApplianceManagerImpl.java	4.08%	138 Missing and 3 partials ⚠️
.../api/response/RouterHealthCheckResultResponse.java	0.00%	2 Missing ⚠️
...m/cloud/network/dao/RouterHealthCheckResultVO.java	0.00%	2 Missing ⚠️
.../apache/cloudstack/framework/config/ConfigKey.java	66.66%	2 Missing ⚠️
...oud/network/lb/ElasticLoadBalancerManagerImpl.java	0.00%	1 Missing ⚠️
.../network/lb/InternalLoadBalancerVMManagerImpl.java	0.00%	1 Missing ⚠️
.../cloud/configuration/ConfigurationManagerImpl.java	92.85%	1 Missing ⚠️
...a/com/cloud/network/router/CommandSetupHelper.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.20   #10710      +/-   ##
============================================
- Coverage     16.13%   16.13%   -0.01%     
+ Complexity    13221    13217       -4     
============================================
  Files          5649     5650       +1     
  Lines        496689   496590      -99     
  Branches      60175    60158      -17     
============================================
- Hits          80153    80133      -20     
+ Misses       407613   407540      -73     
+ Partials       8923     8917       -6     

Flag	Coverage Δ
uitests	4.01% <ø> (-0.01%)	⬇️
unittests	16.98% <23.73%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13050

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12989)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10710-t12989-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13183

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-13166)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13239