Is readyForShutdown predicated on existence of pendings jobs?

[adietrich-ussignal]

When initiating a cancelShutdown, I was attempting to validate the success of the command based on readyforshutdown. I noticed however that readyforshutdown remains true, but I also see that the pendingjobscount for this particular server is 0.

Is the readyforshutdown value predicated on the pendingjobscount, or should it be tied to whether prepareForShutdown is initiated?

Here is the flow of operations for reference:

> prepare forshutdown managementserverid=0b2faa01-706f-4f37-82ff-3e5e8f0971f8
{
  "prepareforshutdown": {
    "managementserverid": 1,
    "pendingjobscount": 0,
    "readyforshutdown": true,
    "shutdowntriggered": true
  }
}
> cancel shutdown managementserverid=0b2faa01-706f-4f37-82ff-3e5e8f0971f8
{
  "cancelshutdown": {
    "managementserverid": 1,
    "pendingjobscount": 0,
    "readyforshutdown": true,
    "shutdowntriggered": false
  }
}
> ready forshutdown managementserverid=0b2faa01-706f-4f37-82ff-3e5e8f0971f8
{
  "readyforshutdown": {
    "managementserverid": 1,
    "pendingjobscount": 0,
    "readyforshutdown": true,
    "shutdowntriggered": false
  }
}

[Pearl1594]

It seems like readyForShutdown is dependent on the value of pendingJobsCount : https://github.com/apache/cloudstack/blob/4.20/plugins/shutdown/src/main/java/org/apache/cloudstack/shutdown/ShutdownManagerImpl.java#L153
i.e., if pendingJobsCount is 0, readyForShutdown is true. But it will proceed to shutdown only if prepareForShutdown is initiated and shutdown is triggered
https://github.com/apache/cloudstack/blob/4.20/plugins/shutdown/src/main/java/org/apache/cloudstack/shutdown/ShutdownManagerImpl.java#L246-L256

[adietrich-ussignal]

Thanks @Pearl1594! For when this is used in other automations, would it make sense to have some sort of additional validation after a shutdown is canceled? There is only shutdowntriggered, but its not indicative of a canceled shutdown, which is really only cancelling after a prepareForShutdown as a triggered shutdown is not recoverable unless the cloudstack-management service is restarted.

[sureshanaparti]

@adietrich-ussignal shutdown triggered can be cancelled only when management server node is still preparing for shutdown (i.e in PreparingToShutdown state - when there are pending jobs to finish), otherwise it is shutdown immediately - needs to restart the cloudstack-management service. There are some improvements here: #9854 (will be part of 4.21 release).

[adietrich-ussignal]

@sureshanaparti Thanks for the response. It sounds like a lot of procedural improvements are coming that will make the module easier to use/more intuitive.