This repository was archived by the owner on Jan 20, 2021. It is now read-only.
Display all data volumes for vm while destroying#915
Merged
yadvr merged 1 commit intoapache:masterfrom Jan 13, 2021
Merged
Conversation
If a root admin tries to destroy VM of different domain then the data disks are not displayed and hence they wont be destroyed. Make sure that root admin can see all data disks of a vm while destroying it
weizhouapache
approved these changes
Jan 11, 2021
Member
weizhouapache
left a comment
weizhouapache
left a comment
There was a problem hiding this comment.
lgtm
this issue does exist in legacy ui as well.
Contributor
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
qrry
added a commit
to qrry/cloudstack-primate
that referenced
this pull request
Jan 14, 2021
* master: Using post for uploadSslCert api (apache#842) Allow enabling network/vpc offering at creation (apache#911) Display all data volumes for vm while destroying (apache#915) tools/docker: Change directory to docker.sh's directory (apache#916) FIX - compute - Create snapshot from virtual machine with managed storage (apache#808) migratewizard: Fix fetching jobid from api response (apache#913) component: remove Primate name from the footer, fix bug report link migratewizard: Display error and unfreeze form when api call fails (apache#912) continue with the Zone deployment without shared primary storage (apache#908) # Conflicts: # src/components/page/GlobalFooter.vue
weizhouapache
pushed a commit
that referenced
this pull request
Jan 19, 2021
If a root admin tries to destroy VM of different domain then the data disks are not displayed and hence they wont be destroyed. Make sure that root admin can see all data disks of a vm while destroying it Co-authored-by: Rakesh Venkatesh <r.venkatesh@global.leaseweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a root admin tries to destroy VM of different
domain then the data disks are not displayed and
hence they wont be destroyed.
Make sure that root admin can see all data disks
of a vm while destroying it
Steps to reproduce:
Expected result:
Root admin should see all two data disks
Actual result:
Root admin doesnt see any data disk
After fix: