Skip to content

Updated SDK with 4.20.1 APIs #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sureshanaparti
Copy link
Contributor

This PR updates SDK with 4.20.1 APIs.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SDK to support v4.20.1 APIs by adding new fields (such as Arch, Usediops, Apikeyaccess, etc.) and updating method signatures to match the latest API responses. Key changes include:

  • Introduction of new response fields (e.g., Arch, Usediops) across multiple services
  • Updates to parameter signatures (e.g., adding an id parameter in account-related methods)
  • Modifications to data type definitions for better type safety

Reviewed Changes

Copilot reviewed 20 out of 31 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cloudstack/SSHService.go Added "Arch" field in response structures
cloudstack/RouterService.go Added "Arch" field and corresponding parameter getters/setters in router responses
cloudstack/PoolService.go Added "Usediops" field in pool responses
cloudstack/NicService.go Added "Arch" field in NIC response structures
cloudstack/NetworkService.go Added "Specifyvlan" field in network responses
cloudstack/NetscalerService.go Added "Specifyvlan" field in load balancer network configurations
cloudstack/ManagementService.go Added new parameter handling for "peers" and new fields in management server responses
cloudstack/LoadBalancerService.go Added "Arch" field in load balancer responses
cloudstack/LDAPService.go Added "Apikeyaccess" field in LDAP account responses
cloudstack/KubernetesService.go Added "Arch" field and updated parameter methods for Kubernetes supported versions
cloudstack/InternalLBService.go Added "Arch" field in internal load balancer VM responses
cloudstack/ISOService.go Added "Arch" field in ISO attach/detach responses
cloudstack/HostService.go Added several host metrics and updated data types (e.g., Memoryallocated type change)
cloudstack/FirewallService.go Added parameter processing for "cidrlist" in port forwarding rules
cloudstack/ConfigurationService.go Added "Usediops" field in storage capability updates
cloudstack/ClusterService.go Added "Arch" field and updated parameter methods in cluster queries
cloudstack/BrocadeVCSService.go Added "Specifyvlan" field in Brocade VCS device network responses
cloudstack/AffinityGroupService.go Added "Arch" field in affinity group responses
cloudstack/AccountService_mock.go Updated method signatures for account offering parameters (added id parameter)
cloudstack/AccountService.go Updated method signatures & response structures (added id parameter and new Apikeyaccess field)
Comments suppressed due to low confidence (3)

cloudstack/PoolService.go:466

  • Consider renaming 'Usediops' to 'UsedIOPS' to improve clarity and align with common capitalization for I/O operations.
	Usediops             int64             `json:"usediops"`

cloudstack/AccountService.go:40

  • The updated method signature now requires an 'id' parameter; ensure that all callers are updated accordingly to avoid breaking changes in the API usage.
	NewIsAccountAllowedToCreateOfferingsWithTagsParams(id string) *IsAccountAllowedToCreateOfferingsWithTagsParams

cloudstack/HostService.go:2243

  • The change in the 'Memoryallocated' field from string to int64 is significant; verify that the API now returns a numeric value to prevent potential type mismatches.
	Memoryallocated                  int64                       `json:"memoryallocated"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants